IDL compiler: EventHandler for setters

Source/bindings/scripts/unstable/v8_attributes.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 106 matching lines @@
     # FIXME: check if compilers are smart enough to inline this, and if so,
     # always use a local variable (for readability and CG simplicity).
     if (attribute.is_nullable or
         idl_type == 'EventHandler' or
         'CachedAttribute' in extended_attributes or
         contents['is_getter_raises_exception']):
         contents['cpp_value_original'] = cpp_value
         cpp_value = 'jsValue'
     contents['cpp_value'] = cpp_value
 
+    # FIXME: always have includes_for_type
     if contents['is_keep_alive_for_gc']:
         v8_set_return_value_statement = 'v8SetReturnValue(info, wrapper)'
         includes.update(v8_types.includes_for_type(idl_type))
         includes.add('bindings/v8/V8HiddenPropertyName.h')
     else:
         v8_set_return_value_statement = v8_types.v8_set_return_value(idl_type, cpp_value, includes, callback_info='info', isolate='info.GetIsolate()', extended_attributes=extended_attributes, script_wrappable='imp')
     contents['v8_set_return_value'] = v8_set_return_value_statement
 
-    if (idl_type == 'EventHandler' and
-        interface.name in ['Window', 'WorkerGlobalScope'] and
-        attribute.name == 'onerror'):
-            includes.add('bindings/v8/V8ErrorHandler.h')
+    if idl_type == 'EventHandler':
+        includes.update(v8_types.includes_for_type('EventHandler'))
+        if (interface.name in ['Window', 'WorkerGlobalScope'] and
+            attribute.name == 'onerror'):
+                includes.add('bindings/v8/V8ErrorHandler.h')
 
     # [CheckSecurityForNode]
     is_check_security_for_node = 'CheckSecurityForNode' in extended_attributes
     if is_check_security_for_node:
         includes.add('bindings/v8/BindingSecurity.h')
     v8_utilities.generate_measure_as(attribute, contents, includes)  # [MeasureAs]
 
     # [DeprecateAs]
     v8_utilities.generate_deprecate_as(attribute, contents, includes)
     if is_check_security_for_node or contents['is_getter_raises_exception']:
@@ skipping 54 matching lines @@
 
 
 def generate_setter(interface, attribute, contents, includes):
     idl_type = attribute.data_type
     if v8_types.is_interface_type(idl_type) and not v8_types.array_type(idl_type):
         cpp_value = 'WTF::getPtr(cppValue)'
     else:
         cpp_value = 'cppValue'
     contents.update({
         'v8_value_to_local_cpp_value': v8_types.v8_value_to_local_cpp_value(idl_type, attribute.extended_attributes, 'jsValue', 'cppValue', includes, 'info.GetIsolate()'),
-        'cpp_setter': setter_expression(interface, attribute, contents),
+        'cpp_setter': setter_expression(interface, attribute, contents, includes),
         'enum_validation_expression': enum_validation_expression(idl_type),
     })
 
 
-def setter_expression(interface, attribute, contents):
+def setter_expression(interface, attribute, contents, includes):
     arguments = v8_utilities.call_with_arguments(attribute, contents)
     idl_type = attribute.data_type
-    # FIXME: should be able to eliminate WTF::getPtr in most or all cases
-    cpp_value = 'WTF::getPtr(cppValue)' if v8_types.is_interface_type(idl_type) and not v8_types.array_type(idl_type) else 'cppValue'
-    arguments.append(cpp_value)
+    if idl_type == 'EventHandler':
+        # FIXME: move V8EventListenerList.h to INCLUDES_FOR_TYPE
+        includes.add('bindings/v8/V8EventListenerList.h')
+        # FIXME: pass the isolate instead of the isolated world
+        isolated_world = 'isolatedWorldForIsolate(info.GetIsolate())'
+        arguments.extend(['V8EventListenerList::getEventListener(jsValue, true, ListenerFindOrCreate)', isolated_world])
+        contents['event_handler_getter_expression'] = 'imp->%s(%s)' % (cpp_name(attribute), isolated_world)
+    elif v8_types.is_interface_type(idl_type) and not v8_types.array_type(idl_type):
+        # FIXME: should be able to eliminate WTF::getPtr in most or all cases
+        arguments.append('WTF::getPtr(cppValue)')
+    else:
+        arguments.append('cppValue')
+
     setter_name = scoped_name(interface, attribute, 'set%s' % capitalize(cpp_name(attribute)))
     return '%s(%s)' % (setter_name, ', '.join(arguments))
 
 
 def enum_validation_expression(idl_type):
     if not v8_types.is_enum_type(idl_type):
         return None
     return ' || '.join(['string == "%s"' % enum_value
                         for enum_value in v8_types.enum_values(idl_type)])
 
@@ skipping 68 matching lines @@
     if 'PerWorldBindings' not in attribute.extended_attributes:
         return '0'
     return '%sV8Internal::%sAttributeGetterCallbackForMainWorld' % (cpp_name(interface), attribute.name)
 
 
 def setter_callback_name_for_main_world(interface, attribute):
     if ('PerWorldBindings' not in attribute.extended_attributes or
         attribute.is_read_only):
         return '0'
     return '%sV8Internal::%sAttributeSetterCallbackForMainWorld' % (cpp_name(interface), attribute.name)