IDL compiler: EventHandler for setters

Source/bindings/templates/attributes.cpp

 {##############################################################################}
 {% macro attribute_getter(attribute, world_suffix) %}
 {% filter conditional(attribute.conditional_string) %}
 static void {{attribute.name}}AttributeGetter{{world_suffix}}(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)
 {
     {% if attribute.is_unforgeable %}
     v8::Handle<v8::Object> holder = info.This()->FindInstanceInPrototypeChain({{v8_class_name}}::GetTemplate(info.GetIsolate(), worldType(info.GetIsolate())));
     if (holder.IsEmpty())
         return;
     {{cpp_class_name}}* imp = {{v8_class_name}}::toNative(holder);
@@ skipping 89 matching lines @@
 }
 {% endfilter %}
 {% endmacro %}
 
 
 {##############################################################################}
 {% macro attribute_setter(attribute, world_suffix) %}
 static void {{attribute.name}}AttributeSetter{{world_suffix}}(v8::Local<v8::String> name, v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)
 {
     {{cpp_class_name}}* imp = {{v8_class_name}}::toNative(info.Holder());
+    {% if attribute.idl_type == 'EventHandler' and interface_name == 'Window' %}
+    if (!imp->document())

[haraken, 2013/10/19 12:41:29]

I think this check should be moved to core/ if the number of affected attribute
setters are not many. (It wouldn't make sense to do the check only for
EventHandler and Window in the binding layer.) How many attribute setters are
using this check?

[Nils Barth (inactive), 2013/10/21 02:41:38]

28 attribute setters.

[haraken, 2013/10/21 03:43:52]

OK, then it would make sense to keep the check in the auto-generated code.
Thanks for the investigation.

[Nils Barth (inactive), 2013/10/21 03:58:34]

Got it, n/p!

+        return;
+    {% endif %}
+    {% if attribute.idl_type != 'EventHandler' %}
     {{attribute.v8_value_to_local_cpp_value}};
+    {% else %}{# EventHandler hack #}
+    {# Non-callable input should be treated as null #}
+    if (!jsValue->IsNull() && !jsValue->IsFunction())
+        jsValue = v8::Null(info.GetIsolate());
+    transferHiddenDependency(info.Holder(), {{attribute.event_handler_getter_expression}}, jsValue, {{v8_class_name}}::eventListenerCacheIndex, info.GetIsolate());
+    {% endif %}
     {% if attribute.is_call_with_script_execution_context %}
     ExecutionContext* scriptContext = getExecutionContext();
     {% endif %}
     {{attribute.cpp_setter}};
     {% if attribute.cached_attribute_validation_method %}
     info.Holder()->DeleteHiddenValue(v8::String::NewSymbol("{{attribute.name}}")); // Invalidate the cached value.
     {% endif %}
 }
 {% endmacro %}
 
 
 {##############################################################################}
 {% macro attribute_setter_callback(attribute, world_suffix) %}
 static void {{attribute.name}}AttributeSetterCallback{{world_suffix}}(v8::Local<v8::String> name, v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)
 {
     TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMSetter");
     {{cpp_class_name}}V8Internal::{{attribute.name}}AttributeSetter{{world_suffix}}(name, jsValue, info);
     TRACE_EVENT_SET_SAMPLING_STATE("V8", "Execution");
 }
 {% endmacro %}