MIPS: modified gypi files to support build

MIPS: modified gypi files to support build

Committed: https://skia.googlesource.com/skia/+/aaf1df632d8d24f797678aebf3332ac67c3de3b5

[djordje, 2014-05-29 12:24:33]

start of new series of smaller patches

[djsollen, 2014-05-29 17:01:08]

https://codereview.chromium.org/304903003/diff/20001/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.chromium.org/304903003/diff/20001/gyp/common_conditions.gy...
gyp/common_conditions.gypi:247: [ 'skia_arch_type == "mips"', {
spacing

https://codereview.chromium.org/304903003/diff/20001/gyp/common_variables.gypi
File gyp/common_variables.gypi (right):

https://codereview.chromium.org/304903003/diff/20001/gyp/common_variables.gyp...
gyp/common_variables.gypi:98: 'skia_arch_type%': 'mips',
I've just submitted a CL to clean this up a little so you will need to rebase on
that.

https://codereview.chromium.org/301173002/

After the rebase I think this should look like...

[ 'skia_arch_type == "mips"', {
    'mips_dsp%': 1,
    'mips_dspr2%': 1,
}],

https://codereview.chromium.org/304903003/diff/20001/gyp/common_variables.gyp...
gyp/common_variables.gypi:100: 'mips_dspr2%': 1,
do you expect all mips builds to support _dsp and dspr2?

[djsollen, 2014-06-02 12:39:09]

https://codereview.chromium.org/304903003/diff/30001/gyp/common_variables.gypi
File gyp/common_variables.gypi (right):

https://codereview.chromium.org/304903003/diff/30001/gyp/common_variables.gyp...
gyp/common_variables.gypi:100: [ 'skia_os == "linux"' and 'skia_arch_type ==
"mips"', {
If you're always going to assign them to 0 then just do it in the level 1
dictionary below and delete this block.

https://codereview.chromium.org/304903003/diff/30001/gyp/common_variables.gyp...
gyp/common_variables.gypi:196: 'mips_dsp%': '<(mips_dsp)',
this can just be...

'mips_dsp%': 0,
'mips_dspr2%': 0,

[djordje, 2014-06-04 16:11:27]

Build-Ubuntu13.10-GCC4.8-Mips-Debug-Mips-Trybot is failing only for target arch
mips32r2 (when -mips32r2 is added to cflags in gyp file). other builds were
successful (-mips64, -mips64r2, -mips32). can we limit build to linux os at this
moment and expand it to android later? any other suggestions?

[djordje, 2014-06-05 07:41:44]

-march=mips32r2 is equivalent to -mips32r2

[djsollen, 2014-06-05 13:25:11]

We only have automated builds/tests for MIPS on Android.  Further, our larger
customers only build for MIPS in the context of Android so introducing a change
that breaks the Android MIPS build seems like a bad idea.  Why not build against
the -march=mips32 as the default instead of mips32r2 if that works for the
Android toolchains?

[djordje, 2014-06-05 16:23:41]

android build should pass now

[djsollen, 2014-06-06 19:11:31]

lgtm

[djordje, 2014-06-06 20:30:00]

The CQ bit was checked by djordje.pesut@imgtec.com

[commit-bot: I haz the power, 2014-06-06 20:31:00]

CQ is trying da patch. Follow status at

https://skia-tree-status.appspot.com/cq/djordje.pesut@imgtec.com/304903003/70002

[commit-bot: I haz the power, 2014-06-06 21:09:15]

Change committed as aaf1df632d8d24f797678aebf3332ac67c3de3b5