Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 304873002: Update Safe Browsing to use net::IsIPAddressReserved (Closed)

Created:
6 years, 6 months ago by Ryan Sleevi
Modified:
6 years, 6 months ago
CC:
chromium-reviews, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -49 lines) Patch
M chrome/browser/safe_browsing/client_side_detection_service.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_service.cc View 4 chunks +3 lines, -41 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Ryan Sleevi
matt: Because waiting for CQ for WebCrypto takes too long, I went and just did ...
6 years, 6 months ago (2014-05-29 02:12:03 UTC) #1
mattm
lgtm
6 years, 6 months ago (2014-05-29 05:06:35 UTC) #2
Ryan Sleevi
The CQ bit was checked by rsleevi@chromium.org
6 years, 6 months ago (2014-05-29 05:08:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/304873002/1
6 years, 6 months ago (2014-05-29 05:08:59 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-05-29 08:40:36 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-29 08:46:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/70362)
6 years, 6 months ago (2014-05-29 08:46:36 UTC) #7
Ryan Sleevi
TBR asvitkine
6 years, 6 months ago (2014-05-30 01:16:13 UTC) #8
Ryan Sleevi
The CQ bit was checked by rsleevi@chromium.org
6 years, 6 months ago (2014-05-30 01:16:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/304873002/1
6 years, 6 months ago (2014-05-30 01:17:21 UTC) #10
commit-bot: I haz the power
Change committed as 273737
6 years, 6 months ago (2014-05-30 06:19:34 UTC) #11
Alexei Svitkine (slow)
histograms lgtm
6 years, 6 months ago (2014-05-30 12:55:22 UTC) #12
Alexei Svitkine (slow)
6 years, 6 months ago (2014-05-30 12:55:22 UTC) #13
Message was sent while issue was closed.
histograms lgtm

Powered by Google App Engine
This is Rietveld 408576698