Issue 304863002: SVG: Remove SVGAnimatedPropertyBase::startAnimation and its overrides which are already all NOOP

Issue 304863002: SVG: Remove SVGAnimatedPropertyBase::startAnimation and its overrides which are already all NOOP (Closed)

Created:
6 years, 6 months ago by kouhei (in TOK)

Modified:
6 years, 6 months ago

Reviewers:
haraken, pdr.

CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, rwlbuis, fs, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, pdr., Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

SVG: Remove SVGAnimatedPropertyBase::startAnimation and its overrides which are already all NOOP TESTS=svg BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175028

Patch Set 1 #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -37 lines)			Patch
M	Source/core/svg/SVGAnimatedAngle.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/svg/SVGAnimatedAngle.cpp	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	Source/core/svg/SVGAnimatedIntegerOptionalInteger.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/svg/SVGAnimatedIntegerOptionalInteger.cpp	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	Source/core/svg/SVGAnimatedNumberOptionalNumber.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/svg/SVGAnimatedNumberOptionalNumber.cpp	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	Source/core/svg/SVGAnimatedTypeAnimator.cpp	View	1 chunk	+0 lines, -2 lines	2 comments	Download
M	Source/core/svg/SVGStaticStringList.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/svg/SVGStaticStringList.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	Source/core/svg/properties/SVGAnimatedProperty.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/svg/properties/SVGAnimatedProperty.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

pdr.

LGTM https://codereview.chromium.org/304863002/diff/1/Source/core/svg/SVGAnimatedTypeAnimator.cpp File Source/core/svg/SVGAnimatedTypeAnimator.cpp (right): https://codereview.chromium.org/304863002/diff/1/Source/core/svg/SVGAnimatedTypeAnimator.cpp#newcode161 Source/core/svg/SVGAnimatedTypeAnimator.cpp:161: void invokeMethodOnAllTargetProperties(const WillBeHeapVector<RawPtrWillBeMember<SVGElement> >& list, const QualifiedName& attributeName, ...

6 years, 6 months ago (2014-05-29 02:03:34 UTC) #2

kouhei (in TOK)

https://codereview.chromium.org/304863002/diff/1/Source/core/svg/SVGAnimatedTypeAnimator.cpp File Source/core/svg/SVGAnimatedTypeAnimator.cpp (right): https://codereview.chromium.org/304863002/diff/1/Source/core/svg/SVGAnimatedTypeAnimator.cpp#newcode161 Source/core/svg/SVGAnimatedTypeAnimator.cpp:161: void invokeMethodOnAllTargetProperties(const WillBeHeapVector<RawPtrWillBeMember<SVGElement> >& list, const QualifiedName& attributeName, SVGAnimatedPropertyMethod ...

6 years, 6 months ago (2014-05-29 02:19:29 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/304863002/1

6 years, 6 months ago (2014-05-29 02:19:48 UTC) #6

Message was sent while issue was closed.

Change committed as 175028

Expand Messages | Collapse Messages