Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Issue 304833002: Add GN build for Linux sandbox. (Closed)

Created:
6 years, 6 months ago by brettw
Modified:
6 years, 6 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, agl, jln+watch_chromium.org
Visibility:
Public.

Description

Add GN build for Linux sandbox. Also removes duplicate gfx x11 target. BUG= R=erg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273589

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+337 lines, -22 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M build/config/linux/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
A sandbox/BUILD.gn View 1 chunk +15 lines, -0 lines 0 comments Download
A sandbox/linux/BUILD.gn View 1 chunk +313 lines, -0 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 1 chunk +3 lines, -0 lines 0 comments Download
D ui/gfx/x/BUILD.gn View 1 chunk +0 lines, -21 lines 0 comments Download
M ui/gl/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
brettw
6 years, 6 months ago (2014-05-28 23:59:32 UTC) #1
Elliot Glaysher
https://codereview.chromium.org/304833002/diff/1/ui/gfx/x/BUILD.gn File ui/gfx/x/BUILD.gn (left): https://codereview.chromium.org/304833002/diff/1/ui/gfx/x/BUILD.gn#oldcode10 ui/gfx/x/BUILD.gn:10: "x11_connection.cc", What happens to this file? It appears to ...
6 years, 6 months ago (2014-05-29 00:06:24 UTC) #2
brettw
new snap up https://codereview.chromium.org/304833002/diff/1/ui/gfx/x/BUILD.gn File ui/gfx/x/BUILD.gn (left): https://codereview.chromium.org/304833002/diff/1/ui/gfx/x/BUILD.gn#oldcode10 ui/gfx/x/BUILD.gn:10: "x11_connection.cc", On 2014/05/29 00:06:24, Elliot Glaysher ...
6 years, 6 months ago (2014-05-29 16:56:34 UTC) #3
Elliot Glaysher
lgtm
6 years, 6 months ago (2014-05-29 17:15:41 UTC) #4
brettw
Committed patchset #2 manually as r273589.
6 years, 6 months ago (2014-05-29 20:56:07 UTC) #5
jln (very slow on Chromium)
Hi Brett, Am I correct that this is WIP and that we'll still be building ...
6 years, 6 months ago (2014-05-29 21:21:39 UTC) #6
brettw
6 years, 6 months ago (2014-05-30 01:19:23 UTC) #7
Message was sent while issue was closed.
On 2014/05/29 21:21:39, jln wrote:
> Hi Brett,
> 
> Am I correct that this is WIP and that we'll still be building with GYP for
now?

Yes, we'll have two systems for a while. The real builds will come from GYP for
a while longer.

> Should I simply add new files in both the .gn file and the .gypi file for now?

Yes, the GN buildbots will ensure that the GN version builds, so if anything
changes it needs to be updated also.

> I would like to make extra sure that Android is working, it took a while to
get
> the GYP version working and we don't have main WF try bots that test all of
it.

I'm curious, what problems did you have with GYP for this?

Powered by Google App Engine
This is Rietveld 408576698