Support automatically resolving dependencies in javascript tests.

chrome/chrome_tests.gypi

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 {
   'includes': [
     'js_unittest_vars.gypi',
   ],
+  'variables': {
+    'chromevox_deps_js_file': '<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/chromeos/chromevox/deps.js',

[dmazzoni, 2014/05/30 17:03:42]

I think it'd make sense to move these into a new gyp file and a new test target.
It's too much special-casing now and it just clutters this file.

+  },
   'targets': [
     {
       'target_name': 'interactive_ui_tests',
       'type': 'executable',
       'dependencies': [
         '../google_apis/google_apis.gyp:google_apis_test_support',
         '../net/net.gyp:net',
         '../net/net.gyp:net_resources',
         '../net/net.gyp:net_test_support',
         '../ppapi/ppapi_internal.gyp:ppapi_tests',
@@ skipping 767 matching lines @@
     {
       # Executable that runs each browser test in a new process.
       'target_name': 'browser_tests',
       'type': 'executable',
       'dependencies': [
         'browser',
         'chrome_resources.gyp:chrome_resources',
         'chrome_resources.gyp:chrome_strings',
         'chrome_resources.gyp:packed_extra_resources',
         'chrome_resources.gyp:packed_resources',
+        'chromevox_generated_browser_tests',
         'common/extensions/api/api.gyp:chrome_api',
         'renderer',
         'test/perf/perf_test.gyp:*',
         'test_support_common',
         'test_support_sync_integration',
         '../apps/common/api/api.gyp:apps_api',
         '../base/base.gyp:base',
         '../base/base.gyp:base_i18n',
         '../base/base.gyp:test_support_base',
         '../components/components.gyp:autofill_content_risk_proto',
@@ skipping 35 matching lines @@
         '../third_party/widevine/cdm/widevine_cdm.gyp:widevine_test_license_server',
       ],
       'include_dirs': [
         '..',
         '<(SHARED_INTERMEDIATE_DIR)',
       ],
       'defines': [
         'HAS_OUT_OF_PROC_TEST_RUNNER',
       ],
       'sources': [
+        '<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/chromeos/chromevox/common/aria_util_test-gen.cc',
         '../apps/app_restore_service_browsertest.cc',
         '../apps/app_window_browsertest.cc',
         '../apps/app_shim/app_shim_host_manager_browsertest_mac.mm',
         '../apps/app_shim/test/app_shim_host_manager_test_api_mac.cc',
         '../apps/app_shim/test/app_shim_host_manager_test_api_mac.h',
         '../apps/load_and_launch_browsertest.cc',
         '../extensions/browser/api/usb/usb_apitest.cc',
         '../extensions/browser/api/usb/usb_manual_apitest.cc',
         '../extensions/renderer/script_context_browsertest.cc',
         # TODO(blundell): Bring up a components_browsertests target and move
@@ skipping 459 matching lines @@
         'browser/renderer_context_menu/render_view_context_menu_browsertest.cc',
         'browser/renderer_context_menu/render_view_context_menu_browsertest_util.cc',
         'browser/renderer_context_menu/render_view_context_menu_browsertest_util.h',
         'browser/renderer_context_menu/render_view_context_menu_test_util.cc',
         'browser/renderer_context_menu/render_view_context_menu_test_util.h',
         'browser/renderer_context_menu/spellchecker_submenu_observer_browsertest.cc',
         'browser/renderer_context_menu/spelling_menu_observer_browsertest.cc',
         'browser/renderer_host/render_process_host_chrome_browsertest.cc',
         'browser/renderer_host/web_cache_manager_browsertest.cc',
         'browser/repost_form_warning_browsertest.cc',
-        'browser/resources/chromeos/chromevox/common/aria_util_test.js',
         'browser/safe_browsing/local_safebrowsing_test_server.cc',
         'browser/safe_browsing/safe_browsing_blocking_page_test.cc',
         'browser/safe_browsing/safe_browsing_service_browsertest.cc',
         'browser/safe_browsing/safe_browsing_test.cc',
         'browser/search/suggestions/thumbnail_manager_browsertest.cc',
         'browser/service_process/service_process_control_browsertest.cc',
         'browser/services/gcm/fake_gcm_profile_service.cc',
         'browser/services/gcm/fake_gcm_profile_service.h',
         'browser/sessions/better_session_restore_browsertest.cc',
         'browser/sessions/persistent_tab_restore_service_browsertest.cc',
@@ skipping 262 matching lines @@
       ],
       'rules': [
         {
           'rule_name': 'js2webui',
           'extension': 'js',
           'msvs_external_rule': 1,
           'inputs': [
             '<(gypv8sh)',
             '<(PRODUCT_DIR)/d8<(EXECUTABLE_SUFFIX)',
             '<(mock_js)',
-            '<(accessibility_audit_js)',
             '<(test_api_js)',
             '<(js2gtest)',
           ],
           'outputs': [
             '<(INTERMEDIATE_DIR)/chrome/<(RULE_INPUT_DIRNAME)/<(RULE_INPUT_ROOT)-gen.cc',
             '<(PRODUCT_DIR)/test_data/chrome/<(RULE_INPUT_DIRNAME)/<(RULE_INPUT_ROOT).js',
           ],
           'process_outputs_as_sources': 1,
           'action': [
             'python',
@@ skipping 413 matching lines @@
             '../remoting/remoting.gyp:remoting_webapp',
           ]
         }, {
           'sources/': [
             ['exclude', '^test/remoting'],
           ],
         }],
       ],  # conditions
     },  # target browser_tests
     {
+      # This library gets included in the browser_tests executable.
+      # It is separated out because the rule to convert js to C++ is
+      # different for ChromeVox tests and it is not possible to have conditions
+      # based on the actual rule input file.
+      # NOTE: This is not a static library because tests in static libraries
+      # are stripped by the linker.  Therefore, sources mentioned in tihis

[David Tseng, 2014/05/30 17:08:46]

this

+      # target must have a corresponding -gen.cc source mentioned in the
+      # browser_tests target above.
+      'target_name': 'chromevox_generated_browser_tests',
+      'type': 'none',
+      'dependencies': [
+        '../testing/gtest.gyp:gtest',
+      ],
+      'defines': [
+        'HAS_OUT_OF_PROC_TEST_RUNNER',
+      ],
+      'include_dirs': [
+        '..',
+        '<(SHARED_INTERMEDIATE_DIR)',
+      ],
+      'rules': [
+        {
+          'rule_name': 'js2webui',
+          'extension': 'js',
+          'msvs_external_rule': 1,
+          'inputs': [
+            '<(gypv8sh)',
+            '<(PRODUCT_DIR)/d8<(EXECUTABLE_SUFFIX)',
+            '<(mock_js)',
+            '<(test_api_js)',
+            '<(js2gtest)',
+            '<(chromevox_deps_js_file)',
+          ],
+          'outputs': [
+            '<(SHARED_INTERMEDIATE_DIR)/chrome/<(RULE_INPUT_DIRNAME)/<(RULE_INPUT_ROOT)-gen.cc',
+            '<(PRODUCT_DIR)/test_data/chrome/<(RULE_INPUT_DIRNAME)/<(RULE_INPUT_ROOT).js',
+          ],
+          'action': [
+            'python',
+            '<(gypv8sh)',
+            '<(PRODUCT_DIR)/d8<(EXECUTABLE_SUFFIX)',
+            '--deps_js', '<(chromevox_deps_js_file)',
+            '<(mock_js)',
+            '<(test_api_js)',
+            '<(js2gtest)',
+            'webui',
+            '<(RULE_INPUT_PATH)',
+            'chrome/<(RULE_INPUT_DIRNAME)/<(RULE_INPUT_ROOT).js',
+            '<@(_outputs)',
+          ],
+        },
+      ],
+      'sources': [
+        'browser/resources/chromeos/chromevox/common/aria_util_test.js',
+      ],
+    },  # target chromevox_browser_tests_lib
+    {
       # Executable that runs each perf browser test in a new process.
       'target_name': 'performance_browser_tests',
       'type': 'executable',
       'dependencies': [
         'browser',
         'chrome_resources.gyp:chrome_resources',
         'chrome_resources.gyp:chrome_strings',
         'chrome_resources.gyp:packed_extra_resources',
         'chrome_resources.gyp:packed_resources',
         'renderer',
@@ skipping 49 matching lines @@
       ],
       'rules': [
         {
           'rule_name': 'js2webui',
           'extension': 'js',
           'msvs_external_rule': 1,
           'inputs': [
             '<(gypv8sh)',
             '<(PRODUCT_DIR)/d8<(EXECUTABLE_SUFFIX)',
             '<(mock_js)',
-            '<(accessibility_audit_js)',
             '<(test_api_js)',
             '<(js2gtest)',
           ],
           'outputs': [
             '<(INTERMEDIATE_DIR)/chrome/<(RULE_INPUT_DIRNAME)/<(RULE_INPUT_ROOT)-gen.cc',
             '<(PRODUCT_DIR)/test_data/chrome/<(RULE_INPUT_DIRNAME)/<(RULE_INPUT_ROOT).js',
           ],
           'process_outputs_as_sources': 1,
           'action': [
             'python',
@@ skipping 465 matching lines @@
       'type': 'none',
       'dependencies': [
         '../base/base.gyp:base',
         '../base/base.gyp:run_all_unittests',
         '../testing/gtest.gyp:gtest',
       ],
       'include_dirs': [
         '..,'
       ],
     },
+    {
+      'target_name': 'chromevox_deps_js',
+      'type': 'none',
+      'actions': [
+        {
+          'action_name': 'deps_js',
+          'message': 'Generate test ChromeVox deps.js',
+          'variables': {
+            'closure_dir': 'third_party/chromevox/third_party/closure-library/closure/goog',
+            'cvox_dir': 'browser/resources/chromeos/chromevox',
+            'depswriter_path': 'third_party/chromevox/third_party/closure-library/closure/bin/build/depswriter.py',
+          },
+          'inputs': [
+            '<!@(python browser/resources/chromeos/chromevox/tools/find_js_files.py <(closure_dir) <(cvox_dir))',
+            '<(depswriter_path)',
+          ],
+          'outputs': [
+            '<(chromevox_deps_js_file)',
+          ],
+          'action': [
+            'python',
+            '<(depswriter_path)',
+            '--root_with_prefix', '<(closure_dir) chrome/<(closure_dir)',
+            '--root_with_prefix', '<(cvox_dir) chrome/<(cvox_dir)',
+            '--output_file', '<(chromevox_deps_js_file)',
+          ],
+        },
+      ],
+    },
   ],
   'conditions': [
     ['OS=="mac"', {
       'targets': [
         {
           # This is the mac equivalent of the security_tests target below. It
           # generates a framework bundle which bundles tests to be run in a
           # renderer process. The test code is built as a framework so it can be
           # run in the context of a renderer without shipping the code to end
           # users.
@@ skipping 383 matching lines @@
             ['enable_webrtc==1', {
               'dependencies': [
                 '../third_party/libjingle/libjingle.gyp:libjingle_webrtc'
               ]
             }],
           ],
         }]
     }],
   ],  # 'conditions'
 }