Trust the renderer's same-document navigation flag if it is a same-origin nav.

content/test/test_render_frame_host.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/test/test_render_frame_host.h"
 
 #include "content/browser/frame_host/frame_tree.h"
 #include "content/common/frame_messages.h"
 #include "content/test/test_render_view_host.h"
 
@@ skipping 28 matching lines @@
 
 void TestRenderFrameHost::SendNavigateWithTransition(
     int page_id,
     const GURL& url,
     PageTransition transition) {
   SendNavigateWithTransitionAndResponseCode(page_id, url, transition, 200);
 }
 
 void TestRenderFrameHost::SendFailedNavigate(int page_id, const GURL& url) {
   SendNavigateWithTransitionAndResponseCode(
-      page_id, url, PAGE_TRANSITION_LINK, 500);
+      page_id, url, PAGE_TRANSITION_RELOAD, 500);
 }
 
 void TestRenderFrameHost::SendNavigateWithTransitionAndResponseCode(
     int page_id,
     const GURL& url, PageTransition transition,
     int response_code) {
   // DidStartProvisionalLoad may delete the pending entry that holds |url|,
   // so we keep a copy of it to use in SendNavigateWithParameters.
   GURL url_copy(url);
   OnDidStartProvisionalLoadForFrame(-1, url_copy);
@@ skipping 46 matching lines @@
   params.referrer = Referrer();
   params.transition = transition;
   params.redirects = redirects;
   params.should_update_history = true;
   params.searchable_form_url = GURL();
   params.searchable_form_encoding = std::string();
   params.security_info = std::string();
   params.gesture = NavigationGestureUser;
   params.contents_mime_type = contents_mime_type_;
   params.is_post = false;
-  params.was_within_same_page = false;
   params.http_status_code = response_code;
   params.socket_address.set_host("2001:db8::1");
   params.socket_address.set_port(80);
   params.history_list_was_cleared = simulate_history_list_was_cleared_;
   params.original_request_url = original_request_url;
 
+  url::Replacements<char> replacements;
+  replacements.ClearRef();
+  params.was_within_same_page = transition != PAGE_TRANSITION_RELOAD &&

[nasko, 2014/05/29 22:59:30]

Why have the transition type being checked? Wouldn't PAGE_TRANSITION_LINK to a
#ref on the page still be considered "within_same_page"?

[Nate Chapin, 2014/05/29 23:03:46]

A link transition can be based on this code.

On the other hand, reloads are never within_same_page, nor are typed urls (i.e.,
the user focusing the address bar and pressing enter).

+      transition != PAGE_TRANSITION_TYPED &&
+      url.ReplaceComponents(replacements) ==
+          GetLastCommittedURL().ReplaceComponents(replacements);
+
   params.page_state = PageState::CreateForTesting(
       url,
       false,
       file_path_for_history_item ? "data" : NULL,
       file_path_for_history_item);
 
   FrameHostMsg_DidCommitProvisionalLoad msg(1, params);
   OnNavigate(msg);
 }
 
 }  // namespace content