Trust the renderer's same-document navigation flag if it is a same-origin nav.

chrome/browser/extensions/active_script_controller_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <map>
 
 #include "base/values.h"
 #include "chrome/browser/extensions/active_script_controller.h"
 #include "chrome/browser/extensions/active_tab_permission_granter.h"
 #include "chrome/browser/extensions/tab_helper.h"
@@ skipping 201 matching lines @@
   // Request an injection. There should be an action visible, but no executions.
   controller()->RequestScriptInjection(
       extension,
       GetPageId(),
       GetExecutionCallbackForExtension(extension->id()));
   EXPECT_TRUE(controller()->GetActionForExtension(extension));
   EXPECT_EQ(0u, GetExecutionCountForExtension(extension->id()));
 
   // Navigate away. This should remove the pending injection, and we should not
   // execute anything.
-  NavigateAndCommit(GURL("https://www.google.com"));
+  Reload();

[nasko, 2014/05/29 22:59:30]

nit: Either the action or the comment is incorrect. They should be in sync.

[Nate Chapin, 2014/05/29 23:03:46]

Depends on your definition of "away" :)

Will clarify.

   EXPECT_FALSE(controller()->GetActionForExtension(extension));
   EXPECT_EQ(0u, GetExecutionCountForExtension(extension->id()));
 
   // Request and accept a new injection.
   controller()->RequestScriptInjection(
       extension,
       GetPageId(),
       GetExecutionCallbackForExtension(extension->id()));
   controller()->OnClicked(extension);
 
@@ skipping 39 matching lines @@
   ASSERT_TRUE(active_tab_permission_granter);
   // Grant the extension active tab permissions. This normally happens, e.g.,
   // if the user clicks on a browser action.
   active_tab_permission_granter->GrantIfRequested(extension);
 
   // Since we have active tab permissions, we shouldn't need user consent
   // anymore.
   EXPECT_FALSE(controller()->RequiresUserConsentForScriptInjection(extension));
 
   // Also test that granting active tab runs any pending tasks.
-  NavigateAndCommit(GURL("https://www.google.com"));
+  Reload();
   // Navigating should mean we need permission again.
   EXPECT_TRUE(controller()->RequiresUserConsentForScriptInjection(extension));
 
   controller()->RequestScriptInjection(
       extension,
       GetPageId(),
       GetExecutionCallbackForExtension(extension->id()));
   EXPECT_TRUE(controller()->GetActionForExtension(extension));
   EXPECT_EQ(0u, GetExecutionCountForExtension(extension->id()));
 
   // Grant active tab.
   active_tab_permission_granter->GrantIfRequested(extension);
 
   // The pending injections should have run since active tab permission was
   // granted.
   EXPECT_EQ(1u, GetExecutionCountForExtension(extension->id()));
   EXPECT_FALSE(controller()->GetActionForExtension(extension));
 }
 
 }  // namespace extensions