Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java

Issue 304763002: Trust the renderer's same-document navigation flag if it is a same-origin nav. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: isNavigationInPage->isFragmentNavigation, with caveat on the name Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.content.browser; 5 package org.chromium.content.browser;
6 6
7 import org.chromium.base.CalledByNative; 7 import org.chromium.base.CalledByNative;
8 import org.chromium.base.JNINamespace; 8 import org.chromium.base.JNINamespace;
9 9
10 /** 10 /**
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 @CalledByNative 48 @CalledByNative
49 public void didFailLoad(boolean isProvisionalLoad, 49 public void didFailLoad(boolean isProvisionalLoad,
50 boolean isMainFrame, int errorCode, String description, String faili ngUrl) { 50 boolean isMainFrame, int errorCode, String description, String faili ngUrl) {
51 } 51 }
52 52
53 /** 53 /**
54 * Called when the main frame of the page has committed. 54 * Called when the main frame of the page has committed.
55 * @param url The validated url for the page. 55 * @param url The validated url for the page.
56 * @param baseUrl The validated base url for the page. 56 * @param baseUrl The validated base url for the page.
57 * @param isNavigationToDifferentPage Whether the main frame navigated to a different page. 57 * @param isNavigationToDifferentPage Whether the main frame navigated to a different page.
58 * @param isNavigationInPage Whether the main frame navigation did not cause changes to the 58 * @param isFragmentNavigation Whether the main frame navigation did not cau se changes to the
59 * document (for example scrolling to a named anch or or PopState). 59 * document (for example scrolling to a named an chor or PopState).
60 */ 60 */
61 @CalledByNative 61 @CalledByNative
62 public void didNavigateMainFrame(String url, String baseUrl, 62 public void didNavigateMainFrame(String url, String baseUrl,
63 boolean isNavigationToDifferentPage, boolean isNavigationInPage) { 63 boolean isNavigationToDifferentPage, boolean isFragmentNavigation) {
64 } 64 }
65 65
66 /** 66 /**
67 * Called when the page had painted something non-empty. 67 * Called when the page had painted something non-empty.
68 */ 68 */
69 @CalledByNative 69 @CalledByNative
70 public void didFirstVisuallyNonEmptyPaint() { 70 public void didFirstVisuallyNonEmptyPaint() {
71 } 71 }
72 72
73 /** 73 /**
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 public void detachFromWebContents() { 160 public void detachFromWebContents() {
161 if (mNativeWebContentsObserverAndroid != 0) { 161 if (mNativeWebContentsObserverAndroid != 0) {
162 nativeDestroy(mNativeWebContentsObserverAndroid); 162 nativeDestroy(mNativeWebContentsObserverAndroid);
163 mNativeWebContentsObserverAndroid = 0; 163 mNativeWebContentsObserverAndroid = 0;
164 } 164 }
165 } 165 }
166 166
167 private native long nativeInit(long contentViewCorePtr); 167 private native long nativeInit(long contentViewCorePtr);
168 private native void nativeDestroy(long nativeWebContentsObserverAndroid); 168 private native void nativeDestroy(long nativeWebContentsObserverAndroid);
169 } 169 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698