Issue 304743003: Fix filter bounds computation for SkOffsetImageFilter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 304743003: Fix filter bounds computation for SkOffsetImageFilter. (Closed)

Created:
6 years, 6 months ago by Stephen White

Modified:
6 years, 6 months ago

Reviewers:
Justin Novosad

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Fix filter bounds computation for SkOffsetImageFilter. SkOffsetImageFilter::onFilterBounds() was not recursing into its input filter when computing bounds. BUG=374556 R=junov@chromium.org Committed: https://code.google.com/p/skia/source/detail?r=14928

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	src/effects/SkOffsetImageFilter.cpp	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
	M	tests/ImageFilterTest.cpp	View		2 chunks	+4 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Justin Novosad

On 2014/05/28 18:26:46, Stephen White wrote: > junov@: PTAL. Thanks! lgtm

6 years, 6 months ago (2014-05-28 19:25:44 UTC) #2

Stephen White

6 years, 6 months ago (2014-05-28 19:29:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r14928 (presubmit successful).