runtime/vm/flow_graph_compiler.cc - Issue 304703002: Split GuardField into GuardFieldType and GuardFieldLength instructions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler.cc

Issue 304703002: Split GuardField into GuardFieldType and GuardFieldLength instructions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler.cc

diff --git a/runtime/vm/flow_graph_compiler.cc b/runtime/vm/flow_graph_compiler.cc

index 063415f769606502262b5a853cd6b2f9f6fbd65c..cafd1f5f692ae6bbb66b04f77980745557e4bf3e 100644

--- a/runtime/vm/flow_graph_compiler.cc

+++ b/runtime/vm/flow_graph_compiler.cc

@@ -256,7 +256,8 @@ void FlowGraphCompiler::EmitInstructionPrologue(Instruction* instr) {

AddCurrentDescriptor(PcDescriptors::kDeopt,

assert->deopt_id(),

assert->token_pos());

- } else if (instr->IsGuardField() ||

+ } else if (instr->IsGuardFieldClass() ||

+ instr->IsGuardFieldLength() ||

Florian Schneider 2014/05/28 14:57:36 Can we just change CanBecomeDeoptimizationTarget()

Vyacheslav Egorov (Google) 2014/05/29 17:36:51 Done.

(instr->CanBecomeDeoptimizationTarget() && !instr->IsGoto())) {

// GuardField and instructions that can be deoptimization targets need

// to record their deopt id. GotoInstr records its own so that it can

« runtime/vm/flow_graph_builder.cc ('K') | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/flow_graph_optimizer.cc » ('j') | runtime/vm/intermediate_language_ia32.cc » ('J')