Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: runtime/vm/raw_object.h

Issue 304703002: Split GuardField into GuardFieldType and GuardFieldLength instructions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_RAW_OBJECT_H_ 5 #ifndef VM_RAW_OBJECT_H_
6 #define VM_RAW_OBJECT_H_ 6 #define VM_RAW_OBJECT_H_
7 7
8 #include "platform/assert.h" 8 #include "platform/assert.h"
9 #include "vm/globals.h" 9 #include "vm/globals.h"
10 #include "vm/token.h" 10 #include "vm/token.h"
(...skipping 667 matching lines...) Expand 10 before | Expand all | Expand 10 after
678 RawArray* dependent_code_; 678 RawArray* dependent_code_;
679 RawSmi* guarded_list_length_; 679 RawSmi* guarded_list_length_;
680 RawObject** to() { 680 RawObject** to() {
681 return reinterpret_cast<RawObject**>(&ptr()->guarded_list_length_); 681 return reinterpret_cast<RawObject**>(&ptr()->guarded_list_length_);
682 } 682 }
683 683
684 intptr_t token_pos_; 684 intptr_t token_pos_;
685 intptr_t guarded_cid_; 685 intptr_t guarded_cid_;
686 intptr_t is_nullable_; // kNullCid if field can contain null value and 686 intptr_t is_nullable_; // kNullCid if field can contain null value and
687 // any other value otherwise. 687 // any other value otherwise.
688 intptr_t guarded_list_length_in_object_offset_;
Florian Schneider 2014/05/28 14:57:36 Make this smaller (int8_t or int16_t) so that the
Vyacheslav Egorov (Google) 2014/05/29 17:36:51 Done.
689
688 uint8_t kind_bits_; // static, final, const, has initializer. 690 uint8_t kind_bits_; // static, final, const, has initializer.
689 }; 691 };
690 692
691 693
692 class RawLiteralToken : public RawObject { 694 class RawLiteralToken : public RawObject {
693 RAW_HEAP_OBJECT_IMPLEMENTATION(LiteralToken); 695 RAW_HEAP_OBJECT_IMPLEMENTATION(LiteralToken);
694 696
695 RawObject** from() { 697 RawObject** from() {
696 return reinterpret_cast<RawObject**>(&ptr()->literal_); 698 return reinterpret_cast<RawObject**>(&ptr()->literal_);
697 } 699 }
(...skipping 1142 matching lines...) Expand 10 before | Expand all | Expand 10 after
1840 COMPILE_ASSERT(kTypedDataInt8ArrayViewCid == kTypedDataInt8ArrayCid + 14); 1842 COMPILE_ASSERT(kTypedDataInt8ArrayViewCid == kTypedDataInt8ArrayCid + 14);
1841 COMPILE_ASSERT(kExternalTypedDataInt8ArrayCid == 1843 COMPILE_ASSERT(kExternalTypedDataInt8ArrayCid ==
1842 kTypedDataInt8ArrayViewCid + 15); 1844 kTypedDataInt8ArrayViewCid + 15);
1843 COMPILE_ASSERT(kNullCid == kExternalTypedDataInt8ArrayCid + 14); 1845 COMPILE_ASSERT(kNullCid == kExternalTypedDataInt8ArrayCid + 14);
1844 return (kNullCid - kTypedDataInt8ArrayCid); 1846 return (kNullCid - kTypedDataInt8ArrayCid);
1845 } 1847 }
1846 1848
1847 } // namespace dart 1849 } // namespace dart
1848 1850
1849 #endif // VM_RAW_OBJECT_H_ 1851 #endif // VM_RAW_OBJECT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698