Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1997)

Unified Diff: Source/devtools/front_end/ResponsiveDesignView.js

Issue 304693002: DevTools: get rid of deviceMetics settings. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/ResponsiveDesignView.js
diff --git a/Source/devtools/front_end/ResponsiveDesignView.js b/Source/devtools/front_end/ResponsiveDesignView.js
index a9b71a9ec27df4c96820c0caeb1243e2a28848b5..22226417bc673d03cfce24e29f20f5bdb75191aa 100644
--- a/Source/devtools/front_end/ResponsiveDesignView.js
+++ b/Source/devtools/front_end/ResponsiveDesignView.js
@@ -357,64 +357,19 @@ WebInspector.ResponsiveDesignView.prototype = {
{
this._toolbarElement = this._responsiveDesignContainer.element.createChild("div", "responsive-design-toolbar");
- const metricsSetting = WebInspector.overridesSupport.settings.deviceMetrics.get();
- var metrics = WebInspector.OverridesSupport.DeviceMetrics.parseSetting(metricsSetting);
-
- /**
- * @this {WebInspector.ResponsiveDesignView}
- */
- function swapDimensionsClicked()
- {
- var widthValue = this._widthOverrideElement.value;
- this._widthOverrideElement.value = this._heightOverrideElement.value;
- this._heightOverrideElement.value = widthValue;
- this._applyDeviceMetricsUserInput();
- }
-
- this._toolbarElement.appendChild(document.createTextNode("Screen")).title = WebInspector.UIString("Screen resolution");
- this._widthOverrideElement = WebInspector.SettingsUI.createInput(this._toolbarElement, "responsive-design-override-width", String(metrics.width), this._applyDeviceMetricsUserInput.bind(this), true, "3em");
+ this._toolbarElement.appendChild(WebInspector.SettingsUI.createSettingCheckbox(WebInspector.UIString("Resolution"), WebInspector.overridesSupport.settings.overrideDeviceResolution, true));
+ this._toolbarElement.appendChild(WebInspector.SettingsUI.createSettingInputField("", WebInspector.overridesSupport.settings.deviceWidth, true, 4, "3em").lastChild);
this._toolbarElement.appendChild(document.createTextNode(" \u00D7 "));
- this._heightOverrideElement = WebInspector.SettingsUI.createInput(this._toolbarElement, "responsive-design-override-height", String(metrics.height), this._applyDeviceMetricsUserInput.bind(this), true, "3em");
+ this._toolbarElement.appendChild(WebInspector.SettingsUI.createSettingInputField("", WebInspector.overridesSupport.settings.deviceHeight, true, 4, "3em").lastChild);
+
this._swapDimensionsElement = this._toolbarElement.createChild("button", "responsive-design-override-swap");
this._swapDimensionsElement.appendChild(document.createTextNode(" \u21C4 ")); // RIGHTWARDS ARROW OVER LEFTWARDS ARROW.
this._swapDimensionsElement.title = WebInspector.UIString("Swap dimensions");
- this._swapDimensionsElement.addEventListener("click", swapDimensionsClicked.bind(this), false);
+ this._swapDimensionsElement.addEventListener("click", WebInspector.overridesSupport.swapDimensions.bind(WebInspector.overridesSupport), false);
this._swapDimensionsElement.tabIndex = -1;
- var span = this._toolbarElement.createChild("span");
- span.textContent = WebInspector.UIString("Dpr");
- span.title = WebInspector.UIString("Device pixel ratio");
- this._deviceScaleFactorOverrideElement = WebInspector.SettingsUI.createInput(this._toolbarElement, "responsive-design-device-scale", String(metrics.deviceScaleFactor), this._applyDeviceMetricsUserInput.bind(this), true, "2em");
-
- var textAutosizingOverrideElement = WebInspector.SettingsUI.createNonPersistedCheckbox(WebInspector.UIString("Enable text autosizing "), this._applyDeviceMetricsUserInput.bind(this));
- textAutosizingOverrideElement.title = WebInspector.UIString("Text autosizing is the feature that boosts font sizes on mobile devices.");
- this._textAutosizingOverrideCheckbox = textAutosizingOverrideElement.firstChild;
- this._textAutosizingOverrideCheckbox.checked = metrics.textAutosizing;
-
- var checkbox = WebInspector.SettingsUI.createSettingCheckbox(WebInspector.UIString("Viewport"), WebInspector.overridesSupport.settings.emulateViewport, true);
- this._toolbarElement.appendChild(checkbox);
-
- WebInspector.overridesSupport.settings.deviceMetrics.addChangeListener(this._updateDeviceMetricsElement, this);
- },
-
- _updateDeviceMetricsElement: function()
- {
- const metricsSetting = WebInspector.overridesSupport.settings.deviceMetrics.get();
- var metrics = WebInspector.OverridesSupport.DeviceMetrics.parseSetting(metricsSetting);
-
- if (this._widthOverrideElement.value != metrics.width)
- this._widthOverrideElement.value = metrics.width;
- if (this._heightOverrideElement.value != metrics.height)
- this._heightOverrideElement.value = metrics.height;
- if (this._deviceScaleFactorOverrideElement.value != metrics.deviceScaleFactor)
- this._deviceScaleFactorOverrideElement.value = metrics.deviceScaleFactor;
- if (this._textAutosizingOverrideCheckbox.checked !== metrics.textAutosizing)
- this._textAutosizingOverrideCheckbox.checked = metrics.textAutosizing;
- },
-
- _applyDeviceMetricsUserInput: function()
- {
- WebInspector.OverridesSupport.DeviceMetrics.applyOverrides(this._widthOverrideElement, this._heightOverrideElement, this._deviceScaleFactorOverrideElement, this._textAutosizingOverrideCheckbox);
+ this._toolbarElement.appendChild(WebInspector.SettingsUI.createSettingCheckbox(WebInspector.UIString("Dpr"), WebInspector.overridesSupport.settings.deviceScaleFactor, true));
+ this._toolbarElement.appendChild(WebInspector.SettingsUI.createSettingCheckbox(WebInspector.UIString("Viewport"), WebInspector.overridesSupport.settings.emulateViewport, true));
},
__proto__: WebInspector.VBox.prototype
« no previous file with comments | « no previous file | Source/devtools/front_end/common/Settings.js » ('j') | Source/devtools/front_end/sdk/OverridesSupport.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698