DevTools: get rid of deviceMetics settings.

Source/devtools/front_end/ui/SettingsUI.js

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 70 matching lines @@
     input.addEventListener("change", inputChanged, false);
 }
 
 /**
  * @param {string} label
  * @param {!WebInspector.Setting} setting
  * @param {boolean} numeric
  * @param {number=} maxLength
  * @param {string=} width
  * @param {function(string):?string=} validatorCallback
+ * @param {boolean=} instant
  */
-WebInspector.SettingsUI.createSettingInputField = function(label, setting, numeric, maxLength, width, validatorCallback)
+WebInspector.SettingsUI.createSettingInputField = function(label, setting, numeric, maxLength, width, validatorCallback, instant)
 {
     var p = document.createElement("p");
     var labelElement = p.createChild("label");
     labelElement.textContent = label;
     var inputElement = p.createChild("input");
     inputElement.value = setting.get();
     inputElement.type = "text";
     if (numeric)
         inputElement.className = "numeric";
     if (maxLength)
         inputElement.maxLength = maxLength;
     if (width)
         inputElement.style.width = width;
 
+    if (validatorCallback || instant) {
+        inputElement.addEventListener("change", onInput, false);
+        inputElement.addEventListener("input", onInput, false);
+    }
+
     var errorMessageLabel;
     if (validatorCallback) {
         errorMessageLabel = p.createChild("div");
         errorMessageLabel.classList.add("field-error-message");
-        inputElement.oninput = onInput;
-        onInput();
+        validate();
     }
 
     function onInput()
     {
+        if (validatorCallback)
+            validate();
+        if (instant)
+            apply();

[dgozman, 2014/05/28 09:39:10]

Why apply if validation failed?

[pfeldman, 2014/05/28 15:07:45]

Done.

+    }
+
+    function validate()
+    {
         var error = validatorCallback(inputElement.value);
         if (!error)
             error = "";
         errorMessageLabel.textContent = error;
     }
 
-    function onBlur()
+    if (!instant)
+        inputElement.addEventListener("blur", apply, false);
+
+    function apply()
     {
+        setting.removeChangeListener(onSettingChange);
         setting.set(numeric ? Number(inputElement.value) : inputElement.value);
+        setting.addChangeListener(onSettingChange);
     }
-    inputElement.addEventListener("blur", onBlur, false);
+
+    setting.addChangeListener(onSettingChange);
+
+    function onSettingChange()
+    {
+        inputElement.value = setting.get();
+    }
 
     return p;
 }
 
 WebInspector.SettingsUI.createCustomSetting = function(name, element)
 {
     var p = document.createElement("p");
     var fieldsetElement = document.createElement("fieldset");
     fieldsetElement.createChild("label").textContent = name;
     fieldsetElement.appendChild(element);
@@ skipping 57 matching lines @@
     element.addEventListener("keydown", keyDownListener, false);
     function keyDownListener(event)
     {
         if (isEnterKey(event))
             eventListener(event);
     }
     return element;
 }
 
 /**
- * @param {string} title
- * @param {function(boolean)} callback
- */
-WebInspector.SettingsUI.createNonPersistedCheckbox = function(title, callback)
-{
-    var labelElement = document.createElement("label");
-    var checkboxElement = labelElement.createChild("input");
-    checkboxElement.type = "checkbox";
-    checkboxElement.checked = false;
-    checkboxElement.addEventListener("click", onclick, false);
-    labelElement.appendChild(document.createTextNode(title));
-    return labelElement;
-
-    function onclick()
-    {
-        callback(checkboxElement.checked);
-    }
-}
-
-/**
  * @constructor
  */
 WebInspector.UISettingDelegate = function()
 {
 }
 
 WebInspector.UISettingDelegate.prototype = {
     /**
      * @return {?Element}
      */
     settingElement: function()
     {
         return null;
     }
 }