Issue 304683002: Add the browser test for the new gallery.

Issue 304683002: Add the browser test for the new gallery. (Closed)

Created:
6 years, 6 months ago by hirono

Modified:
6 years, 6 months ago

Reviewers:
yoshiki

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add the browser test for the new gallery. This CL adds browser tests for the new gallery. The tests are run in the Gallery extension directly as following steps. 1. The test extension contains test cases are loaded by C++. 2. The test extension send a message to the Gallery.app. 3. Gallery.app loads a test from the test extension. BUG=374709 TEST=run the added test. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274481

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 6

Patch Set 4 : Fixed. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+602 lines, -3750 lines)			Patch
M	chrome/browser/chromeos/file_manager/file_manager_browsertest.cc	View	1 2 3	3 chunks	+76 lines, -3 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/file_manager_browsertest/background.js	View	1 2	1 chunk	+0 lines, -814 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/file_manager_browsertest/copy_between_windows.js	View	1 2	1 chunk	+0 lines, -276 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/file_manager_browsertest/create_new_folder.js	View	1 2	1 chunk	+0 lines, -138 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/file_manager_browsertest/drive_specific.js	View	1 2	1 chunk	+0 lines, -169 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/file_manager_browsertest/execute_default_task.js	View	1 2	1 chunk	+0 lines, -66 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/file_manager_browsertest/file_display.js	View	1 2	1 chunk	+0 lines, -52 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/background.js	View	1 2	2 chunks	+0 lines, -246 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/copy_between_windows.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/create_new_folder.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/drive_specific.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/execute_default_task.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/file_display.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/keyboard_operations.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/multi_profile.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/navigation_list.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/open_audio_files.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/open_video_files.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/open_zip_files.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/restore_geometry.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/restore_prefs.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/share_dialog.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/suggest_app_dialog.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/tab_index.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/thumbnails.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/transfer.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/traverse.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager_test_manifest.json	View	1 2 3	1 chunk	+40 lines, -0 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/file_manager_browsertest/gallery/background.js	View		1 chunk	+4 lines, -6 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/file_manager_browsertest/gallery/open_image_files.js	View	1 2 3	1 chunk	+108 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/file_manager_browsertest/gallery/test_loader.js	View		1 chunk	+55 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/file_manager_browsertest/gallery_test_manifest.json	View	1 2 3	1 chunk	+10 lines, -0 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/file_manager_browsertest/keyboard_operations.js	View	1 2	1 chunk	+0 lines, -228 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/file_manager_browsertest/manifest.json	View	1 2	1 chunk	+0 lines, -39 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/file_manager_browsertest/multi_profile.js	View	1 2	1 chunk	+0 lines, -165 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/file_manager_browsertest/navigation_list.js	View	1 2	1 chunk	+0 lines, -88 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/file_manager_browsertest/open_audio_files.js	View	1 2	1 chunk	+0 lines, -524 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/file_manager_browsertest/open_video_files.js	View	1 2	1 chunk	+0 lines, -107 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/file_manager_browsertest/open_zip_files.js	View	1 2	1 chunk	+0 lines, -80 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/file_manager_browsertest/restore_geometry.js	View	1 2	1 chunk	+0 lines, -51 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/file_manager_browsertest/restore_prefs.js	View	1 2	1 chunk	+0 lines, -121 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/file_manager_browsertest/share_dialog.js	View	1 2	1 chunk	+0 lines, -98 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/file_manager_browsertest/suggest_app_dialog.js	View	1 2	1 chunk	+0 lines, -111 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/file_manager_browsertest/tab_index.js	View	1 2	1 chunk	+0 lines, -51 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/file_manager_browsertest/test_util.js	View		1 chunk	+270 lines, -0 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/file_manager_browsertest/thumbnails.js	View	1 2	1 chunk	+0 lines, -38 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/file_manager_browsertest/transfer.js	View	1 2	1 chunk	+0 lines, -185 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/file_manager_browsertest/traverse.js	View	1 2	1 chunk	+0 lines, -70 lines	0 comments	Download
M	ui/file_manager/file_manager/background/js/volume_manager.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/file_manager/gallery/js/background.js	View	1 2 3	2 chunks	+57 lines, -41 lines	0 comments	Download
M	ui/file_manager/gallery/manifest.json	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

yoshiki

lgtm with nits https://codereview.chromium.org/304683002/diff/30001/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc File chrome/browser/chromeos/file_manager/file_manager_browsertest.cc (right): https://codereview.chromium.org/304683002/diff/30001/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc#newcode532 chrome/browser/chromeos/file_manager/file_manager_browsertest.cc:532: return "file_manager_manifest.json"; nit: I think manifest.json ...

6 years, 6 months ago (2014-06-02 21:30:16 UTC) #2

hirono

Thank you! https://codereview.chromium.org/304683002/diff/30001/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc File chrome/browser/chromeos/file_manager/file_manager_browsertest.cc (right): https://codereview.chromium.org/304683002/diff/30001/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc#newcode532 chrome/browser/chromeos/file_manager/file_manager_browsertest.cc:532: return "file_manager_manifest.json"; On 2014/06/02 21:30:16, yoshiki wrote: ...

6 years, 6 months ago (2014-06-03 01:48:41 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/304683002/50001

6 years, 6 months ago (2014-06-03 01:50:28 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_clang_dbg on tryserver.chromium ...

6 years, 6 months ago (2014-06-03 05:53:45 UTC) #6

Message was sent while issue was closed.

Change committed as 274481

Expand Messages | Collapse Messages