Issue 304673002: Revert "Move geometry to mojo/services, extract input events to their own mojom"

Issue 304673002: Revert "Move geometry to mojo/services, extract input events to their own mojom" (Closed)

Created:
6 years, 6 months ago by kinuko

Modified:
6 years, 6 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert "Move geometry to mojo/services, extract input events to their own mojom" Suspected to break compile step: http://build.chromium.org/p/chromium/builders/Linux/builds/50125/steps/compile/logs/stdio#error1 http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/builds/18148/steps/compile/logs/stdio#error1 > Move geometry to mojo/services, extract input events to their own mojom > > R=sky@chromium.org > TBR=sky@chromium.org > http://crbug.com/365012 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273161 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273172

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -248 lines)			Patch
M	mojo/aura/window_tree_host_mojo.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/examples/compositor_app/compositor_app.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	mojo/geometry/DEPS	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	mojo/geometry/geometry_type_converters.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
A +	mojo/geometry/geometry_type_converters.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	mojo/geometry/mojo_geometry_export.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	mojo/mojo.gyp	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	mojo/mojo_public.gypi	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	mojo/mojo_services.gypi	View	2 chunks	+0 lines, -52 lines	0 comments	Download
A +	mojo/public/interfaces/geometry/geometry.mojom	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	mojo/services/native_viewport/DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/services/native_viewport/native_viewport.mojom	View	1 chunk	+19 lines, -2 lines	0 comments	Download
M	mojo/services/native_viewport/native_viewport_service.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
D	mojo/services/public/cpp/geometry/DEPS	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	mojo/services/public/cpp/geometry/geometry_type_converters.h	View	1 chunk	+0 lines, -43 lines	0 comments	Download
D	mojo/services/public/cpp/geometry/lib/geometry_type_converters.cc	View	1 chunk	+0 lines, -52 lines	0 comments	Download
D	mojo/services/public/cpp/geometry/mojo_geometry_export.h	View	1 chunk	+0 lines, -32 lines	0 comments	Download
M	mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
D	mojo/services/public/interfaces/geometry/geometry.mojom	View	1 chunk	+0 lines, -22 lines	0 comments	Download
D	mojo/services/public/interfaces/input_events/input_events.mojom	View	1 chunk	+0 lines, -27 lines	0 comments	Download
M	mojo/services/public/interfaces/view_manager/view_manager.mojom	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/services/view_manager/view_manager_connection.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/services/view_manager/view_manager_connection_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kinuko

Committed patchset #1 manually as r273172 (tree was closed).

6 years, 6 months ago (2014-05-28 07:08:27 UTC) #2

kinuko

6 years, 6 months ago (2014-05-28 08:03:16 UTC) #3

Message was sent while issue was closed.

Sorry for the revert, but the bots have become greener/happier now.

Expand Messages | Collapse Messages