Extend VideoControl to allow clients to request lossless modes.

Extend VideoControl to allow clients to request lossless modes.

- Lossless encode/color requests may be ignored by codecs.
- VideoEncoderVpx supports lossless color when using VP9.
- The --enable-i444 flag now controls the default color mode for VP9.

BUG=260879, 134202
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273752

[Wez, 2014-05-28 21:19:42]

PTAL

There's currently no indication from the host of whether it supports the
lossless control messages; since they're only supported by VP9 it's not really a
host-wide capability, so it's probably best to have the client just understand
that VP9 supports these options while VP8 doesn't.

[Wez, 2014-05-29 17:33:21]

Ping!

[Wez, 2014-05-29 22:10:44]

PTAL

[Jamie, 2014-05-29 22:19:41]

lgtm

https://codereview.chromium.org/304653002/diff/20001/remoting/codec/video_enc...
File remoting/codec/video_encoder_vpx.cc (right):

https://codereview.chromium.org/304653002/diff/20001/remoting/codec/video_enc...
remoting/codec/video_encoder_vpx.cc:105: bool use_i444,
Is i444 the same as lossless colour? Since that's what you've called it in the
public method, it would be better to be consistent here if it's the same thing.

https://codereview.chromium.org/304653002/diff/20001/remoting/codec/video_enc...
File remoting/codec/video_encoder_vpx.h (right):

https://codereview.chromium.org/304653002/diff/20001/remoting/codec/video_enc...
remoting/codec/video_encoder_vpx.h:37: VideoEncoderVpx(bool use_vp9);
Nit: Add explicit?

https://codereview.chromium.org/304653002/diff/20001/remoting/codec/video_enc...
File remoting/codec/video_encoder_vpx_unittest.cc (right):

https://codereview.chromium.org/304653002/diff/20001/remoting/codec/video_enc...
remoting/codec/video_encoder_vpx_unittest.cc:116: TEST(VideoEncoderVpxTest,
TestSizeChangeNoLeak) {
Are the changes to this test essential to this CL? Consider a separate cleanup
CL if not.

[Wez, 2014-05-29 22:39:26]

https://codereview.chromium.org/304653002/diff/20001/remoting/codec/video_enc...
File remoting/codec/video_encoder_vpx.cc (right):

https://codereview.chromium.org/304653002/diff/20001/remoting/codec/video_enc...
remoting/codec/video_encoder_vpx.cc:105: bool use_i444,
On 2014/05/29 22:19:41, Jamie wrote:
> Is i444 the same as lossless colour? Since that's what you've called it in the
> public method, it would be better to be consistent here if it's the same
thing.

Done.

https://codereview.chromium.org/304653002/diff/20001/remoting/codec/video_enc...
File remoting/codec/video_encoder_vpx.h (right):

https://codereview.chromium.org/304653002/diff/20001/remoting/codec/video_enc...
remoting/codec/video_encoder_vpx.h:37: VideoEncoderVpx(bool use_vp9);
On 2014/05/29 22:19:41, Jamie wrote:
> Nit: Add explicit?

Done.

https://codereview.chromium.org/304653002/diff/20001/remoting/codec/video_enc...
File remoting/codec/video_encoder_vpx_unittest.cc (right):

https://codereview.chromium.org/304653002/diff/20001/remoting/codec/video_enc...
remoting/codec/video_encoder_vpx_unittest.cc:116: TEST(VideoEncoderVpxTest,
TestSizeChangeNoLeak) {
On 2014/05/29 22:19:41, Jamie wrote:
> Are the changes to this test essential to this CL? Consider a separate cleanup
> CL if not.

Done.

[Wez, 2014-05-29 22:39:38]

The CQ bit was checked by wez@chromium.org

[commit-bot: I haz the power, 2014-05-29 22:41:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wez@chromium.org/304653002/60001

[Sergey Ulanov, 2014-05-30 05:46:48]

Will we ever want to use lossless encode without lossless color? If not then we
the two flags can be replaced with a single enum. Otherwise LGTM

[commit-bot: I haz the power, 2014-05-30 07:21:23]

Change committed as 273752