Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 304643003: Split interfaces_info between core and modules (Closed)

Created:
6 years, 7 months ago by Nils Barth (inactive)
Modified:
6 years, 7 months ago
Reviewers:
haraken, Nico
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, c.shu
Visibility:
Public.

Description

Split interfaces_info between core and modules GYP split step 3/4 Last remaining step (shown in FIXMEs) is the global constructors. Needed to modify the interfaces_info merging function due to existing of partial interface definitions that cross components, primarily lots of partial interface Navigator in modules. This is not a layering violation (since partial interfaces *extend* interfaces), but it causes added complexity. One nice side effect: touching a core IDL file means we now only need to parse all core files, but not modules files, and conversely for modules, which makes incremental build a bit faster. R=haraken TBR=thakis BUG=358074 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174942

Patch Set 1 #

Patch Set 2 : Comment fixes #

Patch Set 3 : Tweaks #

Patch Set 4 : Comment tweak (reupload) #

Patch Set 5 : Remove excess includes #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+329 lines, -134 lines) Patch
A Source/bindings/core/generated.gyp View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
A Source/bindings/core/idl.gypi View 1 chunk +69 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/generated.gyp View 1 2 3 chunks +11 lines, -80 lines 0 comments Download
M Source/bindings/generated.gyp View 1 2 3 4 3 chunks +11 lines, -2 lines 0 comments Download
M Source/bindings/idl.gypi View 2 chunks +1 line, -47 lines 0 comments Download
A Source/bindings/modules/generated.gyp View 1 2 1 chunk +89 lines, -0 lines 0 comments Download
A Source/bindings/modules/idl.gypi View 1 2 1 chunk +63 lines, -0 lines 3 comments Download
M Source/bindings/modules/v8/generated.gyp View 1 2 3 chunks +9 lines, -4 lines 0 comments Download
M Source/bindings/scripts/compute_interfaces_info_overall.py View 1 2 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Nils Barth (inactive)
Split step 3/4: GYP files in top-level bindings/ dir almost gone!
6 years, 7 months ago (2014-05-28 05:59:36 UTC) #1
haraken
LGTM https://codereview.chromium.org/304643003/diff/70001/Source/bindings/modules/idl.gypi File Source/bindings/modules/idl.gypi (right): https://codereview.chromium.org/304643003/diff/70001/Source/bindings/modules/idl.gypi#newcode27 Source/bindings/modules/idl.gypi:27: # '<@(modules_generated_dependency_idl_files)', Just help me understand: Why is ...
6 years, 7 months ago (2014-05-28 06:14:04 UTC) #2
Nils Barth (inactive)
Thanks, reply! https://codereview.chromium.org/304643003/diff/70001/Source/bindings/modules/idl.gypi File Source/bindings/modules/idl.gypi (right): https://codereview.chromium.org/304643003/diff/70001/Source/bindings/modules/idl.gypi#newcode27 Source/bindings/modules/idl.gypi:27: # '<@(modules_generated_dependency_idl_files)', On 2014/05/28 06:14:04, haraken wrote: ...
6 years, 7 months ago (2014-05-28 06:26:09 UTC) #3
haraken
https://codereview.chromium.org/304643003/diff/70001/Source/bindings/modules/idl.gypi File Source/bindings/modules/idl.gypi (right): https://codereview.chromium.org/304643003/diff/70001/Source/bindings/modules/idl.gypi#newcode27 Source/bindings/modules/idl.gypi:27: # '<@(modules_generated_dependency_idl_files)', On 2014/05/28 06:26:10, Nils Barth wrote: > ...
6 years, 7 months ago (2014-05-28 06:29:24 UTC) #4
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 7 months ago (2014-05-28 06:30:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/304643003/70001
6 years, 7 months ago (2014-05-28 06:30:42 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-28 07:49:55 UTC) #7
Message was sent while issue was closed.
Change committed as 174942

Powered by Google App Engine
This is Rietveld 408576698