Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 304643002: Add unit test for GL_CHROMIUM_sync_query (Closed)

Created:
6 years, 7 months ago by no sievers
Modified:
6 years, 7 months ago
Reviewers:
reveman
CC:
chromium-reviews, piman+watch_chromium.org
Visibility:
Public.

Description

Add unit test for GL_CHROMIUM_sync_query BUG=371530 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273163

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M gpu/command_buffer/tests/gl_query_unittest.cc View 1 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
no sievers
ptal
6 years, 7 months ago (2014-05-27 23:18:45 UTC) #1
reveman
lgtm
6 years, 7 months ago (2014-05-27 23:58:07 UTC) #2
no sievers
The CQ bit was checked by sievers@chromium.org
6 years, 7 months ago (2014-05-27 23:59:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/304643002/1
6 years, 7 months ago (2014-05-27 23:59:33 UTC) #4
reveman
https://codereview.chromium.org/304643002/diff/1/gpu/command_buffer/tests/gl_query_unittest.cc File gpu/command_buffer/tests/gl_query_unittest.cc (right): https://codereview.chromium.org/304643002/diff/1/gpu/command_buffer/tests/gl_query_unittest.cc#newcode166 gpu/command_buffer/tests/gl_query_unittest.cc:166: unsigned int result = 0; nit: GLuint https://codereview.chromium.org/304643002/diff/1/gpu/command_buffer/tests/gl_query_unittest.cc#newcode168 gpu/command_buffer/tests/gl_query_unittest.cc:168: ...
6 years, 7 months ago (2014-05-28 00:03:00 UTC) #5
no sievers
The CQ bit was unchecked by sievers@chromium.org
6 years, 7 months ago (2014-05-28 00:03:18 UTC) #6
reveman
great thanks! still lgtm
6 years, 7 months ago (2014-05-28 00:10:53 UTC) #7
no sievers
The CQ bit was checked by sievers@chromium.org
6 years, 7 months ago (2014-05-28 00:11:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/304643002/10001
6 years, 7 months ago (2014-05-28 00:14:01 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 7 months ago (2014-05-28 03:57:29 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-28 05:45:45 UTC) #11
Message was sent while issue was closed.
Change committed as 273163

Powered by Google App Engine
This is Rietveld 408576698