Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 304633005: ozone: Add ozone_unittests target (Closed)

Created:
6 years, 6 months ago by spang
Modified:
6 years, 6 months ago
Reviewers:
rjkroege, dnicoara
CC:
chromium-reviews, rjkroege, kalyank, ozone-reviews_chromium.org
Visibility:
Public.

Description

ozone: Add ozone_unittests target Move all of our unittests from ui_unittests to ozone_unittests. BUG=none TEST=ozone_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273987

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -48 lines) Patch
M build/all.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/ozone/gfx_ozone.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/ozone.gyp View 2 chunks +17 lines, -0 lines 0 comments Download
D ui/ozone/ozone_unittests.gypi View 1 chunk +0 lines, -30 lines 0 comments Download
M ui/ozone/platform/dri/dri.gypi View 3 chunks +34 lines, -0 lines 0 comments Download
M ui/ozone/platform/dri/dri_surface_factory_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
A + ui/ozone/run_all_unittests.cc View 1 chunk +11 lines, -16 lines 2 comments Download
M ui/ui_unittests.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
spang
6 years, 6 months ago (2014-05-28 20:17:37 UTC) #1
rjkroege
lgtm https://codereview.chromium.org/304633005/diff/1/ui/ozone/run_all_unittests.cc File ui/ozone/run_all_unittests.cc (right): https://codereview.chromium.org/304633005/diff/1/ui/ozone/run_all_unittests.cc#newcode45 ui/ozone/run_all_unittests.cc:45: } all the bad parts of lisp without ...
6 years, 6 months ago (2014-05-30 15:57:49 UTC) #2
spang
https://codereview.chromium.org/304633005/diff/1/ui/ozone/run_all_unittests.cc File ui/ozone/run_all_unittests.cc (right): https://codereview.chromium.org/304633005/diff/1/ui/ozone/run_all_unittests.cc#newcode45 ui/ozone/run_all_unittests.cc:45: } On 2014/05/30 15:57:49, rjkroege wrote: > all the ...
6 years, 6 months ago (2014-05-30 16:47:00 UTC) #3
spang
The CQ bit was checked by spang@chromium.org
6 years, 6 months ago (2014-05-30 16:47:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/304633005/1
6 years, 6 months ago (2014-05-30 16:49:46 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 01:52:40 UTC) #6
Message was sent while issue was closed. 
Change committed as 273987

Powered by Google App Engine
This is Rietveld 408576698