Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Issue 304633004: CallIC::PrintState() was incorrectly declared as V8_FINAL. (Closed)

Created:
6 years, 6 months ago by mvstanton
Modified:
6 years, 6 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

CallIC::PrintState() was incorrectly declared as V8_FINAL. This broke the windows build. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21565

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/code-stubs.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
lgtm.
6 years, 6 months ago (2014-05-28 11:44:06 UTC) #1
mvstanton
6 years, 6 months ago (2014-05-28 11:45:14 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r21565 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698