Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Side by Side Diff: net/quic/quic_packet_creator_test.cc

Issue 304623002: clang_tidy: remove redundant .get() calls on smart ptrs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/quic/quic_framer_test.cc ('k') | net/quic/reliable_quic_stream_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_packet_creator.h" 5 #include "net/quic/quic_packet_creator.h"
6 6
7 #include "base/stl_util.h" 7 #include "base/stl_util.h"
8 #include "net/quic/crypto/null_encrypter.h" 8 #include "net/quic/crypto/null_encrypter.h"
9 #include "net/quic/crypto/quic_decrypter.h" 9 #include "net/quic/crypto/quic_decrypter.h"
10 #include "net/quic/crypto/quic_encrypter.h" 10 #include "net/quic/crypto/quic_encrypter.h"
(...skipping 635 matching lines...) Expand 10 before | Expand all | Expand 10 after
646 versions.push_back(test::QuicVersionMax()); 646 versions.push_back(test::QuicVersionMax());
647 scoped_ptr<QuicEncryptedPacket> encrypted( 647 scoped_ptr<QuicEncryptedPacket> encrypted(
648 creator_.SerializeVersionNegotiationPacket(versions)); 648 creator_.SerializeVersionNegotiationPacket(versions));
649 649
650 { 650 {
651 InSequence s; 651 InSequence s;
652 EXPECT_CALL(framer_visitor_, OnPacket()); 652 EXPECT_CALL(framer_visitor_, OnPacket());
653 EXPECT_CALL(framer_visitor_, OnUnauthenticatedPublicHeader(_)); 653 EXPECT_CALL(framer_visitor_, OnUnauthenticatedPublicHeader(_));
654 EXPECT_CALL(framer_visitor_, OnVersionNegotiationPacket(_)); 654 EXPECT_CALL(framer_visitor_, OnVersionNegotiationPacket(_));
655 } 655 }
656 client_framer_.ProcessPacket(*encrypted.get()); 656 client_framer_.ProcessPacket(*encrypted);
657 } 657 }
658 658
659 TEST_P(QuicPacketCreatorTest, UpdatePacketSequenceNumberLengthLeastAwaiting) { 659 TEST_P(QuicPacketCreatorTest, UpdatePacketSequenceNumberLengthLeastAwaiting) {
660 EXPECT_EQ(PACKET_1BYTE_SEQUENCE_NUMBER, 660 EXPECT_EQ(PACKET_1BYTE_SEQUENCE_NUMBER,
661 creator_.options()->send_sequence_number_length); 661 creator_.options()->send_sequence_number_length);
662 662
663 creator_.set_sequence_number(64); 663 creator_.set_sequence_number(64);
664 creator_.UpdateSequenceNumberLength(2, 10000); 664 creator_.UpdateSequenceNumberLength(2, 10000);
665 EXPECT_EQ(PACKET_1BYTE_SEQUENCE_NUMBER, 665 EXPECT_EQ(PACKET_1BYTE_SEQUENCE_NUMBER,
666 creator_.options()->send_sequence_number_length); 666 creator_.options()->send_sequence_number_length);
(...skipping 177 matching lines...) Expand 10 before | Expand all | Expand 10 after
844 // After 64 calls, BoolSource will refresh the bucket - make sure it does. 844 // After 64 calls, BoolSource will refresh the bucket - make sure it does.
845 mock_random_.ChangeValue(); 845 mock_random_.ChangeValue();
846 } 846 }
847 847
848 delete frames_[0].stream_frame; 848 delete frames_[0].stream_frame;
849 } 849 }
850 850
851 } // namespace 851 } // namespace
852 } // namespace test 852 } // namespace test
853 } // namespace net 853 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/quic_framer_test.cc ('k') | net/quic/reliable_quic_stream_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698