Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issue 304603006: Revert of Set proper referrer for css resource fetching (Closed)

Created:
6 years, 6 months ago by bashi
Modified:
6 years, 6 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis, Kunihiko Sakamoto, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert of Set proper referrer for css resource fetching (https://codereview.chromium.org/239353007/) Reason for revert: Caused regression Original issue's description: > Set proper referrer for css resource fetching > > Fetching css resources are initiated as follows: > - Create FetchRequest > - Call ResourceFetcher::fetchXXX() > > git-grep shows me that CSSImageValue, CSSImageSetValue and > CSSFontFaceSrcValue are all of the resource fetch initiators > which live in css/. I think that setting referrer in these > classes should cover all css resource fetching. > > Since resource fetching is delayed until the resource is actually > needed, we need to hold the referrer somewhere. > This CL modifies the css parser to set referrer to corresponding > CSSValue (CSSImageValue and CSSFontFaceSrcValue) when it sees url(...). > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172433 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175004

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -268 lines) Patch
D LayoutTests/http/tests/css/css-resources-referrer.html View 1 chunk +0 lines, -48 lines 0 comments Download
D LayoutTests/http/tests/css/css-resources-referrer-expected.html View 1 chunk +0 lines, -34 lines 0 comments Download
D LayoutTests/http/tests/css/css-resources-referrer-srcdoc.html View 1 chunk +0 lines, -36 lines 0 comments Download
D LayoutTests/http/tests/css/css-resources-referrer-srcdoc-expected.html View 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/http/tests/css/resources/css-resources-referrer.css View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/http/tests/css/resources/css-resources-referrer-import.css View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/http/tests/css/resources/referrer-check.php View 1 chunk +0 lines, -52 lines 0 comments Download
M Source/core/css/CSSCursorImageValue.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSFontFaceSrcValue.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSFontFaceSrcValue.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/css/CSSImageSetValue.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSImageSetValue.cpp View 3 chunks +2 lines, -5 lines 0 comments Download
M Source/core/css/CSSImageValue.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/css/CSSImageValue.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 8 chunks +6 lines, -14 lines 0 comments Download
M Source/core/html/HTMLBodyElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLTableElement.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M Source/core/html/HTMLTablePartElement.cpp View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
bashi
Created Revert of Set proper referrer for css resource fetching
6 years, 6 months ago (2014-05-28 12:07:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bashi@chromium.org/304603006/1
6 years, 6 months ago (2014-05-28 12:08:16 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-28 12:08:17 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-05-28 12:08:17 UTC) #4
bashi
6 years, 6 months ago (2014-05-28 12:18:06 UTC) #5
jochen (gone - plz use gerrit)
lgtm
6 years, 6 months ago (2014-05-28 12:22:40 UTC) #6
bashi
The CQ bit was checked by bashi@chromium.org
6 years, 6 months ago (2014-05-28 12:23:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bashi@chromium.org/304603006/1
6 years, 6 months ago (2014-05-28 12:24:47 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-05-28 13:45:07 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-28 14:40:28 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/9463)
6 years, 6 months ago (2014-05-28 14:40:28 UTC) #11
bashi
The CQ bit was checked by bashi@chromium.org
6 years, 6 months ago (2014-05-28 21:57:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bashi@chromium.org/304603006/1
6 years, 6 months ago (2014-05-28 21:57:40 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 22:51:00 UTC) #14
Message was sent while issue was closed.
Change committed as 175004

Powered by Google App Engine
This is Rietveld 408576698