Issue 3046016: Restrict new tab button clicks to inside the image bounds, not anywhere in th...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3046016: Restrict new tab button clicks to inside the image bounds, not anywhere in th... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by pink

Modified:
4 years ago

Reviewers:
rohitrao (OOO until 6-22)

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Restrict new tab button clicks to inside the image bounds, not anywhere in the bounds of the button in the nib. Nib change: Make the new tab button a subclass of NewTabButton instead of NSButton BUG=45738 TEST=clicking new tab button still works as expected. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53488

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 4

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+161 lines, -33 lines)			Patch
M	chrome/app/nibs/BrowserWindow.xib	View		21 chunks	+98 lines, -33 lines	0 comments	Download
A	chrome/browser/cocoa/new_tab_button.h	View	1 2 3	1 chunk	+23 lines, -0 lines	0 comments	Download
A	chrome/browser/cocoa/new_tab_button.mm	View	1 2 3	1 chunk	+38 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Trybot results:

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

rohitrao (OOO until 6-22)

http://codereview.chromium.org/3046016/diff/4001/5003 File chrome/browser/cocoa/new_tab_button.mm (right): http://codereview.chromium.org/3046016/diff/4001/5003#newcode30 chrome/browser/cocoa/new_tab_button.mm:30: return NO; return nil; http://codereview.chromium.org/3046016/diff/4001/5004 File chrome/chrome_browser.gypi (right): http://codereview.chromium.org/3046016/diff/4001/5004#newcode907 ...

4 years, 10 months ago (2010-07-23 16:15:36 UTC) #2

pink

idiotic mistakes fixed. check again. http://codereview.chromium.org/3046016/diff/4001/5003 File chrome/browser/cocoa/new_tab_button.mm (right): http://codereview.chromium.org/3046016/diff/4001/5003#newcode30 chrome/browser/cocoa/new_tab_button.mm:30: return NO; On 2010/07/23 ...

4 years, 10 months ago (2010-07-23 16:24:41 UTC) #3

rohitrao (OOO until 6-22)

4 years, 10 months ago (2010-07-23 17:11:30 UTC) #5

lgtm

On Jul 23, 2010 12:38 PM, <pinkerton@chromium.org> wrote:
> New version uploaded with path cached.
>
> http://codereview.chromium.org/3046016/show

Expand Messages | Collapse Messages