Issue 304593004: H264 decoder for webRTC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 304593004: H264 decoder for webRTC. (Closed)

Created:
6 years, 7 months ago by hshi1

Modified:
6 years, 4 months ago

Reviewers:
Stefan

CC:
chromium-reviews, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Patch Set 3 : Rebased at 283560. #

Patch Set 4 : Using fragmentation header. #

Total comments: 2

Patch Set 6 : Fix off-by-one error in fragmentation offsets. #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -32 lines)			Patch
M	content/renderer/media/rtc_video_decoder.cc	View	1 2 3	3 chunks	+10 lines, -3 lines	0 comments	Download
M	content/renderer/media/rtc_video_encoder.cc	View	1 2 3 4 5	2 chunks	+23 lines, -8 lines	0 comments	Download
M	content/renderer/media/rtc_video_encoder_factory.cc	View		3 chunks	+17 lines, -21 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Stefan

https://codereview.chromium.org/304593004/diff/60001/content/renderer/media/rtc_video_encoder.cc File content/renderer/media/rtc_video_encoder.cc (right): https://codereview.chromium.org/304593004/diff/60001/content/renderer/media/rtc_video_encoder.cc#newcode679 content/renderer/media/rtc_video_encoder.cc:679: header.fragmentationLength[0] = length - 3; Shouldn't this be header.fragmentationLength[i]

6 years, 4 months ago (2014-08-07 19:17:27 UTC) #1

hshi1

6 years, 4 months ago (2014-08-07 19:32:10 UTC) #2

https://codereview.chromium.org/304593004/diff/60001/content/renderer/media/r...
File content/renderer/media/rtc_video_encoder.cc (right):

https://codereview.chromium.org/304593004/diff/60001/content/renderer/media/r...
content/renderer/media/rtc_video_encoder.cc:679: header.fragmentationLength[0] =
length - 3;
On 2014/08/07 19:17:27, Stefan wrote:
> Shouldn't this be header.fragmentationLength[i]

sorry for the typo, yes this should be [i] not [0]. after this the decoder is
indeed initialized so I can investigate further. Still getting decode errors
though.

Expand Messages | Collapse Messages

Issue 304593004: H264 decoder for webRTC. (Closed)

Description

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Rebased at 283560. #

Patch Set 4 : Using fragmentation header. #

Patch Set 5 : Fix a typo. #

Patch Set 6 : Fix off-by-one error in fragmentation offsets. #

Messages