Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: trunk/src/mojo/shell/shell_test_helper.cc

Issue 304593002: Revert 272983 "Change Shell / ShellClient to ServiceProvider" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/mojo/shell/shell_test_helper.h ('k') | trunk/src/mojo/shell/view_manager_loader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/mojo/shell/shell_test_helper.cc
===================================================================
--- trunk/src/mojo/shell/shell_test_helper.cc (revision 272983)
+++ trunk/src/mojo/shell/shell_test_helper.cc (working copy)
@@ -19,7 +19,7 @@
struct ShellTestHelper::State {
scoped_ptr<Context> context;
scoped_ptr<ServiceManager::TestAPI> test_api;
- ScopedMessagePipeHandle service_provider_handle;
+ ScopedMessagePipeHandle shell_handle;
};
namespace {
@@ -28,28 +28,28 @@
state->context.reset(new Context);
state->test_api.reset(
new ServiceManager::TestAPI(state->context->service_manager()));
- state->service_provider_handle = state->test_api->GetServiceProviderHandle();
+ state->shell_handle = state->test_api->GetShellHandle();
}
} // namespace
-class ShellTestHelper::TestServiceProvider : public ServiceProvider {
+class ShellTestHelper::TestShellClient : public ShellClient {
public:
- TestServiceProvider() {}
- virtual ~TestServiceProvider() {}
+ TestShellClient() {}
+ virtual ~TestShellClient() {}
- // ServiceProvider:
- virtual void ConnectToService(
+ // ShellClient:
+ virtual void AcceptConnection(
const mojo::String& url,
ScopedMessagePipeHandle client_handle) OVERRIDE {
}
private:
- DISALLOW_COPY_AND_ASSIGN(TestServiceProvider);
+ DISALLOW_COPY_AND_ASSIGN(TestShellClient);
};
ShellTestHelper::ShellTestHelper()
- : service_provider_thread_("shell_test_helper"),
+ : shell_thread_("shell_test_helper"),
state_(NULL) {
base::CommandLine::Init(0, NULL);
mojo::shell::InitializeLogging();
@@ -59,7 +59,7 @@
if (state_) {
// |state_| contains data created on the background thread. Destroy it
// there so that there aren't any race conditions.
- service_provider_thread_.message_loop()->DeleteSoon(FROM_HERE, state_);
+ shell_thread_.message_loop()->DeleteSoon(FROM_HERE, state_);
state_ = NULL;
}
}
@@ -67,23 +67,20 @@
void ShellTestHelper::Init() {
DCHECK(!state_);
state_ = new State;
- service_provider_thread_.Start();
- base::MessageLoopProxy* message_loop_proxy =
- service_provider_thread_.message_loop()->message_loop_proxy();
- message_loop_proxy->PostTaskAndReply(
+ shell_thread_.Start();
+ shell_thread_.message_loop()->message_loop_proxy()->PostTaskAndReply(
FROM_HERE,
base::Bind(&StartShellOnShellThread, state_),
- base::Bind(&ShellTestHelper::OnServiceProviderStarted,
- base::Unretained(this)));
+ base::Bind(&ShellTestHelper::OnShellStarted, base::Unretained(this)));
run_loop_.reset(new base::RunLoop);
run_loop_->Run();
}
-void ShellTestHelper::OnServiceProviderStarted() {
+void ShellTestHelper::OnShellStarted() {
DCHECK(state_);
- local_service_provider_.reset(new TestServiceProvider);
- service_provider_.Bind(state_->service_provider_handle.Pass());
- service_provider_.set_client(local_service_provider_.get());
+ shell_client_.reset(new TestShellClient);
+ shell_.Bind(state_->shell_handle.Pass());
+ shell_.set_client(shell_client_.get());
run_loop_->Quit();
}
« no previous file with comments | « trunk/src/mojo/shell/shell_test_helper.h ('k') | trunk/src/mojo/shell/view_manager_loader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698