Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1485)

Unified Diff: trunk/src/mojo/shell/dbus_service_loader_linux.cc

Issue 304593002: Revert 272983 "Change Shell / ShellClient to ServiceProvider" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/mojo/shell/dbus_service_loader_linux.h ('k') | trunk/src/mojo/shell/dynamic_service_loader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/mojo/shell/dbus_service_loader_linux.cc
===================================================================
--- trunk/src/mojo/shell/dbus_service_loader_linux.cc (revision 272983)
+++ trunk/src/mojo/shell/dbus_service_loader_linux.cc (working copy)
@@ -37,12 +37,12 @@
LoadContext(DBusServiceLoader* loader,
const scoped_refptr<dbus::Bus>& bus,
const GURL& url,
- ScopedMessagePipeHandle service_provider_handle)
+ ScopedMessagePipeHandle shell_handle)
: loader_(loader),
bus_(bus),
service_dbus_proxy_(NULL),
url_(url),
- service_provider_handle_(service_provider_handle.Pass()),
+ shell_handle_(shell_handle.Pass()),
keep_alive_(loader->context_) {
base::PostTaskAndReplyWithResult(
loader_->context_->task_runners()->io_runner(),
@@ -108,8 +108,7 @@
mojo::AllocationScope scope;
external_service_->Activate(
mojo::ScopedMessagePipeHandle(
- mojo::MessagePipeHandle(
- service_provider_handle_.release().value())));
+ mojo::MessagePipeHandle(shell_handle_.release().value())));
}
// Should the ExternalService disappear completely, destroy connection state.
@@ -133,7 +132,7 @@
scoped_refptr<dbus::Bus> bus_;
dbus::ObjectProxy* service_dbus_proxy_; // Owned by bus_;
const GURL url_;
- ScopedMessagePipeHandle service_provider_handle_;
+ ScopedMessagePipeHandle shell_handle_;
KeepAlive keep_alive_;
scoped_ptr<common::ChannelInit> channel_init_;
ExternalServicePtr external_service_;
« no previous file with comments | « trunk/src/mojo/shell/dbus_service_loader_linux.h ('k') | trunk/src/mojo/shell/dynamic_service_loader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698