Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: trunk/src/mojo/service_manager/service_manager_unittest.cc

Issue 304593002: Revert 272983 "Change Shell / ShellClient to ServiceProvider" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/mojo/service_manager/service_manager_unittest.cc
===================================================================
--- trunk/src/mojo/service_manager/service_manager_unittest.cc (revision 272983)
+++ trunk/src/mojo/service_manager/service_manager_unittest.cc (working copy)
@@ -3,11 +3,10 @@
// found in the LICENSE file.
#include "base/message_loop/message_loop.h"
-#include "mojo/public/cpp/application/application.h"
-#include "mojo/public/cpp/application/application.h"
#include "mojo/public/cpp/bindings/allocation_scope.h"
#include "mojo/public/cpp/environment/environment.h"
-#include "mojo/public/interfaces/service_provider/service_provider.mojom.h"
+#include "mojo/public/cpp/shell/application.h"
+#include "mojo/public/interfaces/shell/shell.mojom.h"
#include "mojo/service_manager/service_loader.h"
#include "mojo/service_manager/service_manager.h"
#include "mojo/service_manager/test.mojom.h"
@@ -94,12 +93,11 @@
int num_loads() const { return num_loads_; }
private:
- virtual void LoadService(
- ServiceManager* manager,
- const GURL& url,
- ScopedMessagePipeHandle service_provider_handle) OVERRIDE {
+ virtual void LoadService(ServiceManager* manager,
+ const GURL& url,
+ ScopedMessagePipeHandle shell_handle) OVERRIDE {
++num_loads_;
- test_app_.reset(new Application(service_provider_handle.Pass()));
+ test_app_.reset(new Application(shell_handle.Pass()));
test_app_->AddService<TestServiceImpl>(context_);
}
@@ -168,7 +166,7 @@
service_manager_->set_default_loader(
scoped_ptr<ServiceLoader>(default_loader));
- service_manager_->ConnectToService(test_url, pipe.handle1.Pass());
+ service_manager_->Connect(test_url, pipe.handle1.Pass());
}
virtual void TearDown() OVERRIDE {
@@ -243,21 +241,21 @@
// test::test1 should go to url_loader.
MessagePipe pipe1;
- sm.ConnectToService(GURL("test:test1"), pipe1.handle0.Pass());
+ sm.Connect(GURL("test:test1"), pipe1.handle0.Pass());
EXPECT_EQ(1, url_loader->num_loads());
EXPECT_EQ(0, scheme_loader->num_loads());
EXPECT_EQ(0, default_loader->num_loads());
// test::test2 should go to scheme loader.
MessagePipe pipe2;
- sm.ConnectToService(GURL("test:test2"), pipe2.handle0.Pass());
+ sm.Connect(GURL("test:test2"), pipe2.handle0.Pass());
EXPECT_EQ(1, url_loader->num_loads());
EXPECT_EQ(1, scheme_loader->num_loads());
EXPECT_EQ(0, default_loader->num_loads());
// http::test1 should go to default loader.
MessagePipe pipe3;
- sm.ConnectToService(GURL("http:test1"), pipe3.handle0.Pass());
+ sm.Connect(GURL("http:test1"), pipe3.handle0.Pass());
EXPECT_EQ(1, url_loader->num_loads());
EXPECT_EQ(1, scheme_loader->num_loads());
EXPECT_EQ(1, default_loader->num_loads());
@@ -272,7 +270,7 @@
std::string url("test:test3");
MessagePipe pipe1;
- sm.ConnectToService(GURL(url), pipe1.handle0.Pass());
+ sm.Connect(GURL(url), pipe1.handle0.Pass());
EXPECT_EQ(1, interceptor.call_count());
EXPECT_EQ(url, interceptor.url_spec());
EXPECT_EQ(1, default_loader->num_loads());
« no previous file with comments | « trunk/src/mojo/service_manager/service_manager.cc ('k') | trunk/src/mojo/services/native_viewport/native_viewport_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698