trunk/src/mojo/service_manager/background_service_loader.h - Issue 304593002: Revert 272983 "Change Shell / ShellClient to ServiceProvider"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/src/mojo/service_manager/background_service_loader.h

Issue 304593002: Revert 272983 "Change Shell / ShellClient to ServiceProvider" (Closed) Base URL: svn://svn.chromium.org/chrome/

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: trunk/src/mojo/service_manager/background_service_loader.h

===================================================================

--- trunk/src/mojo/service_manager/background_service_loader.h (revision 272983)

+++ trunk/src/mojo/service_manager/background_service_loader.h (working copy)

@@ -38,10 +38,9 @@

// to |background_loader_| to do the actual loading.

// TODO: having this code take a |manager| is fragile (as ServiceManager isn't

// thread safe).

- void LoadServiceOnBackgroundThread(

- ServiceManager* manager,

- const GURL& url,

- ScopedMessagePipeHandle* service_provider_handle);

+ void LoadServiceOnBackgroundThread(ServiceManager* manager,

+ const GURL& url,

+ ScopedMessagePipeHandle* shell_handle);

void OnServiceErrorOnBackgroundThread(ServiceManager* manager,

const GURL& url);

void ShutdownOnBackgroundThread();