Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1096)

Unified Diff: trunk/src/content/browser/mojo/mojo_application_host.h

Issue 304593002: Revert 272983 "Change Shell / ShellClient to ServiceProvider" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/src/content/browser/mojo/mojo_application_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/content/browser/mojo/mojo_application_host.h
===================================================================
--- trunk/src/content/browser/mojo/mojo_application_host.h (revision 272983)
+++ trunk/src/content/browser/mojo/mojo_application_host.h (working copy)
@@ -8,7 +8,7 @@
#include "base/process/process_handle.h"
#include "mojo/common/channel_init.h"
#include "mojo/embedder/scoped_platform_handle.h"
-#include "mojo/public/interfaces/service_provider/service_provider.mojom.h"
+#include "mojo/public/interfaces/shell/shell.mojom.h"
namespace IPC {
class Sender;
@@ -34,29 +34,27 @@
bool did_activate() const { return did_activate_; }
- mojo::ServiceProvider* service_provider() {
- DCHECK(child_service_provider_.get());
- return child_service_provider_->client();
+ mojo::ShellClient* shell_client() {
+ DCHECK(shell_.get());
+ return shell_->client();
}
private:
- class ServiceProviderImpl
- : public mojo::InterfaceImpl<mojo::ServiceProvider> {
+ class ShellImpl : public mojo::InterfaceImpl<mojo::Shell> {
public:
virtual void OnConnectionError() OVERRIDE {
// TODO(darin): How should we handle this error?
}
- // mojo::ServiceProvider methods:
- virtual void ConnectToService(
- const mojo::String& url,
- mojo::ScopedMessagePipeHandle handle) OVERRIDE;
+ // mojo::Shell methods:
+ virtual void Connect(const mojo::String& url,
+ mojo::ScopedMessagePipeHandle handle) OVERRIDE;
};
mojo::common::ChannelInit channel_init_;
mojo::embedder::ScopedPlatformHandle client_handle_;
- scoped_ptr<ServiceProviderImpl> child_service_provider_;
+ scoped_ptr<ShellImpl> shell_;
bool did_activate_;
« no previous file with comments | « no previous file | trunk/src/content/browser/mojo/mojo_application_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698