Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Unified Diff: trunk/src/content/browser/mojo/mojo_application_host.cc

Issue 304593002: Revert 272983 "Change Shell / ShellClient to ServiceProvider" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/content/browser/mojo/mojo_application_host.cc
===================================================================
--- trunk/src/content/browser/mojo/mojo_application_host.cc (revision 272983)
+++ trunk/src/content/browser/mojo/mojo_application_host.cc (working copy)
@@ -30,7 +30,7 @@
}
bool MojoApplicationHost::Init() {
- DCHECK(!child_service_provider_.get()) << "Already initialized!";
+ DCHECK(!shell_.get()) << "Already initialized!";
mojo::embedder::PlatformChannelPair channel_pair;
@@ -43,8 +43,7 @@
// Forward this to the client once we know its process handle.
client_handle_ = channel_pair.PassClientHandle();
- child_service_provider_.reset(
- BindToPipe(new ServiceProviderImpl(), message_pipe.Pass()));
+ shell_.reset(BindToPipe(new ShellImpl(), message_pipe.Pass()));
return true;
}
@@ -60,7 +59,7 @@
return did_activate_;
}
-void MojoApplicationHost::ServiceProviderImpl::ConnectToService(
+void MojoApplicationHost::ShellImpl::Connect(
const mojo::String& url,
mojo::ScopedMessagePipeHandle handle) {
// TODO(darin): Provide something meaningful here.

Powered by Google App Engine
This is Rietveld 408576698