Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 304563002: DevTools: Make frameworks work with "custom" breakpoints (DOM, XHR, Events). (Closed)

Created:
6 years, 6 months ago by aandrey
Modified:
6 years, 6 months ago
Reviewers:
pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Make frameworks work with "custom" breakpoints (DOM, XHR, Events). BUG=267592 R=pfeldman, yurys Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175136

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+323 lines, -347 lines) Patch
M LayoutTests/http/tests/inspector/debugger-test.js View 4 chunks +49 lines, -2 lines 0 comments Download
D LayoutTests/inspector/sources/debugger/async-callstack-and-framework-black-box.html View 1 chunk +0 lines, -87 lines 0 comments Download
D LayoutTests/inspector/sources/debugger/async-callstack-and-framework-black-box-expected.txt View 1 chunk +0 lines, -37 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/dom-breakpoints.html View 12 chunks +12 lines, -50 lines 0 comments Download
A LayoutTests/inspector/sources/debugger/frameworks-dom-xhr-event-breakpoints.html View 1 chunk +85 lines, -0 lines 0 comments Download
A LayoutTests/inspector/sources/debugger/frameworks-dom-xhr-event-breakpoints-expected.txt View 1 chunk +29 lines, -0 lines 0 comments Download
A + LayoutTests/inspector/sources/debugger/frameworks-skip-step-in.html View 1 chunk +4 lines, -5 lines 0 comments Download
A LayoutTests/inspector/sources/debugger/frameworks-skip-step-in-expected.txt View 1 chunk +34 lines, -0 lines 0 comments Download
A + LayoutTests/inspector/sources/debugger/frameworks-with-async-callstack.html View 1 chunk +3 lines, -17 lines 0 comments Download
A LayoutTests/inspector/sources/debugger/frameworks-with-async-callstack-expected.txt View 1 chunk +38 lines, -0 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/resources/framework.js View 1 chunk +44 lines, -0 lines 0 comments Download
D LayoutTests/inspector/sources/debugger/skip-stack-frames-steps.html View 1 chunk +0 lines, -97 lines 0 comments Download
D LayoutTests/inspector/sources/debugger/skip-stack-frames-steps-expected.txt View 1 chunk +0 lines, -34 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.h View 1 2 chunks +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 1 13 chunks +24 lines, -17 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
aandrey
6 years, 6 months ago (2014-05-27 14:15:51 UTC) #1
yurys
lgtm https://codereview.chromium.org/304563002/diff/1/Source/core/inspector/InspectorDebuggerAgent.cpp File Source/core/inspector/InspectorDebuggerAgent.cpp (right): https://codereview.chromium.org/304563002/diff/1/Source/core/inspector/InspectorDebuggerAgent.cpp#newcode107 Source/core/inspector/InspectorDebuggerAgent.cpp:107: , m_stepLikePauseScheduled(false) m_debuggerStepScheduled?
6 years, 6 months ago (2014-05-28 17:15:59 UTC) #2
aandrey
https://codereview.chromium.org/304563002/diff/1/Source/core/inspector/InspectorDebuggerAgent.cpp File Source/core/inspector/InspectorDebuggerAgent.cpp (right): https://codereview.chromium.org/304563002/diff/1/Source/core/inspector/InspectorDebuggerAgent.cpp#newcode107 Source/core/inspector/InspectorDebuggerAgent.cpp:107: , m_stepLikePauseScheduled(false) On 2014/05/28 17:15:59, yurys wrote: > m_debuggerStepScheduled? ...
6 years, 6 months ago (2014-05-29 09:01:23 UTC) #3
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 6 months ago (2014-05-29 09:01:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/304563002/20001
6 years, 6 months ago (2014-05-29 09:03:15 UTC) #5
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 6 months ago (2014-05-30 12:26:13 UTC) #6
aandrey
The CQ bit was unchecked by aandrey@chromium.org
6 years, 6 months ago (2014-05-30 12:26:14 UTC) #7
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 6 months ago (2014-05-30 12:26:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/304563002/40001
6 years, 6 months ago (2014-05-30 12:27:53 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 14:36:52 UTC) #10
Message was sent while issue was closed. 
Change committed as 175136

Powered by Google App Engine
This is Rietveld 408576698