Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 304553002: Replace STATIC_CHECK with STATIC_ASSERT. (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Replace STATIC_CHECK with STATIC_ASSERT. It's just an alias, and STATIC_ASSERT is used way more often BUG=none R=jkummerow@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=21527

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -83 lines) Patch
M src/arm/code-stubs-arm.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/arm/codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/codegen-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/checks.h View 3 chunks +2 lines, -8 lines 0 comments Download
M src/contexts.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap.h View 1 chunk +6 lines, -5 lines 0 comments Download
M src/heap-snapshot-generator.cc View 8 chunks +15 lines, -13 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/code-stubs-mips.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/mips/codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 15 chunks +20 lines, -20 lines 0 comments Download
M src/objects-inl.h View 3 chunks +6 lines, -6 lines 0 comments Download
M src/runtime.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/spaces.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/code-stubs-x87.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/x87/codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-05-27 12:56:44 UTC) #1
Jakob Kummerow
LGTM if this makes you happy :-) Looking for more needless duplication? PrintF vs. OS::Print!
6 years, 7 months ago (2014-05-27 13:03:25 UTC) #2
jochen (gone - plz use gerrit)
yes, yes. very happy.
6 years, 7 months ago (2014-05-27 13:42:49 UTC) #3
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-05-27 13:43:44 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 manually as r21527 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698