content/browser/service_worker/service_worker_registration.cc - Issue 304543002: Show the unregistered workers in chrome://serviceworker-internals and chrome://inspect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_registration.cc

Issue 304543002: Show the unregistered workers in chrome://serviceworker-internals and chrome://inspect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated falken's comment Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/resources/service_worker/serviceworker_internals.html ('K') | « content/browser/service_worker/service_worker_internals_ui.cc ('k') | content/browser/service_worker/service_worker_storage.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_registration.cc

diff --git a/content/browser/service_worker/service_worker_registration.cc b/content/browser/service_worker/service_worker_registration.cc

index 1baeda7ca1a3ae11e6563a6ec8e82db356d8d3a9..b389a153217a2cad783924fac04c0fb18915ac33 100644

--- a/content/browser/service_worker/service_worker_registration.cc

+++ b/content/browser/service_worker/service_worker_registration.cc

@@ -36,6 +36,7 @@ ServiceWorkerRegistrationInfo ServiceWorkerRegistration::GetInfo() {

return ServiceWorkerRegistrationInfo(

script_url(),

pattern(),

+ registration_id_,

active_version_ ? active_version_->GetInfo() : ServiceWorkerVersionInfo(),

pending_version_ ? pending_version_->GetInfo()

: ServiceWorkerVersionInfo());