Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Unified Diff: content/browser/resources/service_worker/serviceworker_internals.html

Issue 304543002: Show the unregistered workers in chrome://serviceworker-internals and chrome://inspect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: incorporated falken's comment Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/resources/service_worker/serviceworker_internals.html
diff --git a/content/browser/resources/service_worker/serviceworker_internals.html b/content/browser/resources/service_worker/serviceworker_internals.html
index 867b89774124d9970ff22130c686e1575a96b714..017ac08e896bb60708b2667b45343196590af7da 100644
--- a/content/browser/resources/service_worker/serviceworker_internals.html
+++ b/content/browser/resources/service_worker/serviceworker_internals.html
@@ -2,7 +2,7 @@
<html i18n-values="dir:textdirection;">
<head>
<meta charset="utf-8">
- <title>ServiceWorker registrations</title>
+ <title>ServiceWorker</title>
<link rel="stylesheet" href="chrome://resources/css/tabs.css">
<link rel="stylesheet" href="chrome://resources/css/widgets.css">
<link rel="stylesheet" href="serviceworker_internals.css">
@@ -31,50 +31,72 @@
<span>Renderer thread ID:</span>
<span jscontent="$this.thread_id"></span>
</div>
+ <div class="serviceworker-rid">
+ <span>DevTools agent route ID:</span>
+ <span jscontent="$this.devtools_agent_route_id"></span>
+ </div>
<div>
<div>Log:</div>
<textarea class="serviceworker-log"
jsvalues=".partition_id:$partition_id;.version_id:$this.version_id"
- rows="10" cols="120" readonly jscontent="$this.log"></textarea>
+ rows="3" cols="120" readonly jscontent="$this.log"></textarea>
+ </div>
+ <div class="worker-controls">
+ <button href="#" class="stop" jsdisplay="$this.running_status == 'RUNNING'"
+ jsvalues=".cmdArgs:{partition_id:$partition_id,version_id:version_id}">Stop</button>
+ <button href="#" class="sync" jsdisplay="$this.running_status == 'RUNNING'"
+ jsvalues=".cmdArgs:{partition_id:$partition_id,version_id:version_id}">Sync</button>
+ <button href="#" class="inspect" jsdisplay="$this.running_status == 'RUNNING'"
+ jsvalues=".cmdArgs:{process_id:process_id,devtools_agent_route_id:devtools_agent_route_id}">Inspect</button>
falken 2014/05/28 16:26:06 html files in chrome also should adhere to 80 col
horo 2014/05/29 01:31:25 I will do so in another cl. http://www.chromium.or
+ <span class="operation-status" style="display: none">Running...</span>
+ </div>
+ </div>
+ <div id="serviceworker-registration-template" class="serviceworker-registration">
+ <div class="serviceworker-scope">
+ <span>Scope:</span>
+ <span jscontent="scope"></span>
+ </div>
+ <div class="serviceworker-script_url">
+ <span>Script:</span>
+ <span jscontent="script_url"></span>
+ </div>
+ <div class="serviceworker-rid">
+ <span>Registration ID:</span>
+ <span jscontent="registration_id"></span>
+ <span jsdisplay="$this.unregistered">(unregistered)</span>
+ </div>
+ <div jsselect="$this.active">
+ Active worker:
+ <div transclude="serviceworker-version-template"></div>
+ </div>
+ <div jsselect="$this.pending">
+ Pending worker:
+ <div transclude="serviceworker-version-template"></div>
+ </div>
+ <div class="registration-controls" jsdisplay="!$this.unregistered">
+ <button href="#" class="unregister"
+ jsvalues=".cmdArgs:{partition_id:$partition_id,scope:scope}">Unregister</button>
+ <button href="#" class="start" jsdisplay="$this.active.running_status != 'RUNNING'"
+ jsvalues=".cmdArgs:{partition_id:$partition_id,scope:scope}">Start</button>
+ <span class="operation-status" style="display: none">Running...</span>
</div>
</div>
<div id="serviceworker-list-template"
jsvalues="$partition_id:$this.partition_id;$partition_path:$this.partition_path;.partition_path:$this.partition_path">
<div class="serviceworker-summary">
- <span>Instances in: </span>
+ <span>Registrations in: </span>
<span jscontent="$this.partition_path"></span>
- <span jscontent="'(' + $this.registrations.length + ')'"></span>
- </div>
- <div class="serviceworker-item" jsselect="$this.registrations">
- <div class="serviceworker-scope">
- <span>Scope:</span>
- <span jscontent="scope"></span>
- </div>
- <div class="serviceworker-script_url">
- <span>Script:</span>
- <span jscontent="script_url"></span>
- </div>
- <div jsselect="$this.active">
- Active worker:
- <div transclude="serviceworker-version-template"></div>
- </div>
- <div jsselect="$this.pending">
- Pending worker:
- <div transclude="serviceworker-version-template"></div>
- </div>
- <div class="controls">
- <button class="stop" jsdisplay="$this.active.running_status == 'RUNNING'"
- jsvalues=".scope:scope;.partition_path:$partition_path">Stop</button>
- <button href="#" class="start" jsdisplay="$this.active.running_status != 'RUNNING'"
- jsvalues=".scope:scope;.partition_path:$partition_path">Start</button>
- <button href="#" class="unregister"
- jsvalues=".scope:scope;.partition_path:$partition_path">Unregister</button>
- <button href="#" class="sync" jsdisplay="$this.active.running_status == 'RUNNING'"
- jsvalues=".scope:scope;.partition_path:$partition_path">Sync</button>
- <button href="#" class="inspect" jsdisplay="$this.active.running_status == 'RUNNING'"
- jsvalues=".scope:scope;.partition_path:$partition_path">Inspect</button>
- <span class="operation-status" style="display: none">Running...</span>
- </div>
+ <span jscontent="'(' + $this.stored_registrations.length + ')'"></span>
+ </div>
+ <div class="serviceworker-item" jsselect="$this.stored_registrations">
+ <div transclude="serviceworker-registration-template"></div>
+ </div>
+ <div class="serviceworker-item" jsselect="$this.unregistered_registrations">
+ <div transclude="serviceworker-registration-template"></div>
+ </div>
+ <div class="serviceworker-item" jsselect="$this.unregistered_versions">
+ Unregistered worker:
+ <div transclude="serviceworker-version-template"></div>
</div>
</div>
</div>

Powered by Google App Engine
This is Rietveld 408576698