Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 304513007: Remove PlatformFile from ppapi (Closed)

Created:
6 years, 7 months ago by rvargas (doing something else)
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove PlatformFile from ppapi BUG=322664 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274377

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -112 lines) Patch
M ppapi/nacl_irt/ppapi_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/file_io_resource.h View 7 chunks +28 lines, -27 lines 0 comments Download
M ppapi/proxy/file_io_resource.cc View 17 chunks +37 lines, -50 lines 0 comments Download
M ppapi/proxy/file_mapping_resource.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/file_mapping_resource.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ppapi/proxy/file_mapping_resource_posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/file_mapping_resource_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppp_content_decryptor_private_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/proxy_channel.cc View 1 chunk +1 line, -5 lines 0 comments Download
M ppapi/proxy/serialized_handle.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M ppapi/shared_impl/file_type_conversion.cc View 3 chunks +9 lines, -10 lines 0 comments Download
M ppapi/shared_impl/platform_file.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/var.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
rvargas (doing something else)
PTAL
6 years, 6 months ago (2014-05-31 02:01:20 UTC) #1
dmichael (off chromium)
teravest@, could you take this one please?
6 years, 6 months ago (2014-06-02 15:56:00 UTC) #2
teravest
lgtm
6 years, 6 months ago (2014-06-02 16:09:42 UTC) #3
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 6 months ago (2014-06-02 23:28:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/304513007/40001
6 years, 6 months ago (2014-06-02 23:29:11 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 00:01:06 UTC) #6
Message was sent while issue was closed.
Change committed as 274377

Powered by Google App Engine
This is Rietveld 408576698