[DevTools] Fix regression: console message doesn't filter by source url.

Source/devtools/front_end/console/ConsoleView.js

Index: Source/devtools/front_end/console/ConsoleView.js
diff --git a/Source/devtools/front_end/console/ConsoleView.js b/Source/devtools/front_end/console/ConsoleView.js
index ed272511dec2ae6275a28bd294efb17047ed3541..7c7067e73888434651b71aa6d53cc5f3c22e9df7 100644
--- a/Source/devtools/front_end/console/ConsoleView.js
+++ b/Source/devtools/front_end/console/ConsoleView.js
@@ -512,12 +512,13 @@ WebInspector.ConsoleView.prototype = {
         contextMenu.appendCheckboxItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Preserve log upon navigation" : "Preserve Log upon Navigation"), preserveLogItemAction, WebInspector.settings.preserveConsoleLog.get());
 
         var sourceElement = event.target.enclosingNodeOrSelfWithClass("console-message-wrapper");
+        var consoleMessage = sourceElement && sourceElement.message.consoleMessage();

[lushnikov, 2014/05/28 09:10:21]

Please use ternary operator

[Dmitry Zvorygin, 2014/05/28 11:38:10]

Done.

 
         var filterSubMenu = contextMenu.appendSubMenuItem(WebInspector.UIString("Filter"));
 
-        if (sourceElement && sourceElement.message.url) {
-            var menuTitle = WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Hide messages from %s" : "Hide Messages from %s", new WebInspector.ParsedURL(sourceElement.message.url).displayName);
-            filterSubMenu.appendItem(menuTitle, this._filter.addMessageURLFilter.bind(this._filter, sourceElement.message.url));
+        if (consoleMessage.url) {

[lushnikov, 2014/05/28 09:10:21]

consoleMessage might be null here

[Dmitry Zvorygin, 2014/05/28 11:38:10]

Done.

+            var menuTitle = WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Hide messages from %s" : "Hide Messages from %s", new WebInspector.ParsedURL(consoleMessage.url).displayName);
+            filterSubMenu.appendItem(menuTitle, this._filter.addMessageURLFilter.bind(this._filter, consoleMessage.url));
         }
 
         filterSubMenu.appendSeparator();
@@ -531,13 +532,13 @@ WebInspector.ConsoleView.prototype = {
             hasFilters = true;
         }
 
-        filterSubMenu.setEnabled(hasFilters || (sourceElement && sourceElement.message.url));
+        filterSubMenu.setEnabled(hasFilters || (consoleMessage && consoleMessage.url));
         unhideAll.setEnabled(hasFilters);
 
         contextMenu.appendSeparator();
         contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Clear console" : "Clear Console"), this._requestClearMessages.bind(this));
 
-        var request = (sourceElement && sourceElement.message) ? sourceElement.message.request : null;
+        var request = consoleMessage ? consoleMessage.request : null;
         if (request && request.type === WebInspector.resourceTypes.XHR) {
             contextMenu.appendSeparator();
             contextMenu.appendItem(WebInspector.UIString("Replay XHR"), NetworkAgent.replayXHR.bind(null, request.requestId));