Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 304503004: [DevTools] Fix regression: console message doesn't filter by source url. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
4 * Copyright (C) 2009 Joseph Pecoraro 4 * Copyright (C) 2009 Joseph Pecoraro
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 case WebInspector.ConsoleMessage.MessageType.Profile: 157 case WebInspector.ConsoleMessage.MessageType.Profile:
158 case WebInspector.ConsoleMessage.MessageType.ProfileEnd: 158 case WebInspector.ConsoleMessage.MessageType.ProfileEnd:
159 this._messageElement = this._format([consoleMessage.mess ageText]); 159 this._messageElement = this._format([consoleMessage.mess ageText]);
160 break; 160 break;
161 default: 161 default:
162 var args = consoleMessage.parameters || [consoleMessage. messageText]; 162 var args = consoleMessage.parameters || [consoleMessage. messageText];
163 this._messageElement = this._format(args); 163 this._messageElement = this._format(args);
164 } 164 }
165 } else if (consoleMessage.source === WebInspector.ConsoleMessage.Mes sageSource.Network) { 165 } else if (consoleMessage.source === WebInspector.ConsoleMessage.Mes sageSource.Network) {
166 if (consoleMessage.request) { 166 if (consoleMessage.request) {
167 consoleMessage.stackTrace = consoleMessage.request.initiator .stackTrace;
168 if (consoleMessage.request.initiator && consoleMessage.reque st.initiator.url) {
169 consoleMessage.url = consoleMessage.request.initiator.ur l;
170 consoleMessage.line = consoleMessage.request.initiator.l ineNumber;
171 }
172 this._messageElement = document.createElement("span"); 167 this._messageElement = document.createElement("span");
173 if (consoleMessage.level === WebInspector.ConsoleMessage.Mes sageLevel.Error) { 168 if (consoleMessage.level === WebInspector.ConsoleMessage.Mes sageLevel.Error) {
174 this._messageElement.appendChild(document.createTextNode (consoleMessage.request.requestMethod + " ")); 169 this._messageElement.appendChild(document.createTextNode (consoleMessage.request.requestMethod + " "));
175 this._messageElement.appendChild(WebInspector.Linkifier. linkifyUsingRevealer(consoleMessage.request, consoleMessage.request.url, console Message.request.url)); 170 this._messageElement.appendChild(WebInspector.Linkifier. linkifyUsingRevealer(consoleMessage.request, consoleMessage.request.url, console Message.request.url));
176 if (consoleMessage.request.failed) 171 if (consoleMessage.request.failed)
177 this._messageElement.appendChild(document.createText Node(" " + consoleMessage.request.localizedFailDescription)); 172 this._messageElement.appendChild(document.createText Node(" " + consoleMessage.request.localizedFailDescription));
178 else 173 else
179 this._messageElement.appendChild(document.createText Node(" " + consoleMessage.request.statusCode + " (" + consoleMessage.request.sta tusText + ")")); 174 this._messageElement.appendChild(document.createText Node(" " + consoleMessage.request.statusCode + " (" + consoleMessage.request.sta tusText + ")"));
180 } else { 175 } else {
181 var fragment = WebInspector.linkifyStringAsFragmentWithC ustomLinkifier(consoleMessage.messageText, linkifyRequest.bind(consoleMessage)); 176 var fragment = WebInspector.linkifyStringAsFragmentWithC ustomLinkifier(consoleMessage.messageText, linkifyRequest.bind(consoleMessage));
(...skipping 1047 matching lines...) Expand 10 before | Expand all | Expand 10 after
1229 { 1224 {
1230 if (!this._wrapperElement) { 1225 if (!this._wrapperElement) {
1231 WebInspector.ConsoleViewMessage.prototype.toMessageElement.call(this ); 1226 WebInspector.ConsoleViewMessage.prototype.toMessageElement.call(this );
1232 this._wrapperElement.classList.toggle("collapsed", this._collapsed); 1227 this._wrapperElement.classList.toggle("collapsed", this._collapsed);
1233 } 1228 }
1234 return this._wrapperElement; 1229 return this._wrapperElement;
1235 }, 1230 },
1236 1231
1237 __proto__: WebInspector.ConsoleViewMessage.prototype 1232 __proto__: WebInspector.ConsoleViewMessage.prototype
1238 } 1233 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698