[DevTools] Fix regression: console message doesn't filter by source url.

[DevTools] Fix regression: console message doesn't filter by source url.

BUG=376770
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174976

[Dmitry Zvorygin, 2014-05-27 16:22:57]

Please take a look.

[lushnikov, 2014-05-28 09:10:21]

https://codereview.chromium.org/304503004/diff/1/Source/devtools/front_end/co...
File Source/devtools/front_end/console/ConsoleView.js (right):

https://codereview.chromium.org/304503004/diff/1/Source/devtools/front_end/co...
Source/devtools/front_end/console/ConsoleView.js:515: var consoleMessage =
sourceElement && sourceElement.message.consoleMessage();
Please use ternary operator

https://codereview.chromium.org/304503004/diff/1/Source/devtools/front_end/co...
Source/devtools/front_end/console/ConsoleView.js:519: if (consoleMessage.url) {
consoleMessage might be null here

[Dmitry Zvorygin, 2014-05-28 11:38:10]

Please take a look.

https://codereview.chromium.org/304503004/diff/1/Source/devtools/front_end/co...
File Source/devtools/front_end/console/ConsoleView.js (right):

https://codereview.chromium.org/304503004/diff/1/Source/devtools/front_end/co...
Source/devtools/front_end/console/ConsoleView.js:515: var consoleMessage =
sourceElement && sourceElement.message.consoleMessage();
On 2014/05/28 09:10:21, lushnikov wrote:
> Please use ternary operator

Done.

https://codereview.chromium.org/304503004/diff/1/Source/devtools/front_end/co...
Source/devtools/front_end/console/ConsoleView.js:519: if (consoleMessage.url) {
On 2014/05/28 09:10:21, lushnikov wrote:
> consoleMessage might be null here

Done.

[lushnikov, 2014-05-28 11:55:18]

lgtm

[Dmitry Zvorygin, 2014-05-28 12:37:03]

The CQ bit was checked by zvorygin@chromium.org

[commit-bot: I haz the power, 2014-05-28 12:37:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zvorygin@chromium.org/304503004/20001

[commit-bot: I haz the power, 2014-05-28 13:54:21]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/6349)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/9455)

[Dmitry Zvorygin, 2014-05-28 13:57:56]

@vsevik, I need owners LGTM.

[commit-bot: I haz the power, 2014-05-28 14:06:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-28 14:06:39]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/6355)

[aandrey, 2014-05-28 14:57:33]

lgtm

[Dmitry Zvorygin, 2014-05-28 14:58:54]

The CQ bit was checked by zvorygin@chromium.org

[commit-bot: I haz the power, 2014-05-28 14:59:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zvorygin@chromium.org/304503004/20001

[commit-bot: I haz the power, 2014-05-28 16:01:23]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/9468)

[vsevik, 2014-05-28 17:31:40]

lgtm

[commit-bot: I haz the power, 2014-05-28 17:47:30]

Change committed as 174976