Issue 3045003: Reapply r52859

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3045003: Reapply r52859 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by tfarina

Modified:
4 years ago

Reviewers:
John Gregg

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
git://git.chromium.org/chromium.git

Visibility:
Public.

Reapply r52859 This reverts commit a3d08737344176477998ba74549b3a23a72cdc96. This fix the win trybot by adding a missing ALLOW_THIS_IN_INITIALIZER_LIST macro necessary to silent the VS compiler. BUG=None TEST=trybots TBR=johnnyg@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52868

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+91 lines, -136 lines)			Patch
M	chrome/browser/gtk/notifications/balloon_view_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/gtk/notifications/notification_options_menu_model.h	View	1 chunk	+0 lines, -43 lines	0 comments	Download
D	chrome/browser/gtk/notifications/notification_options_menu_model.cc	View	1 chunk	+0 lines, -90 lines	0 comments	Download
A	chrome/browser/notifications/notification_options_menu_model.h	View	1 chunk	+30 lines, -0 lines	0 comments	Download
A	chrome/browser/notifications/notification_options_menu_model.cc	View	1 chunk	+58 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Trybot results: linux mac win