Issue 304493002: Remove global pretenuring mode.

Issue 304493002: Remove global pretenuring mode. (Closed)

Created:
6 years, 7 months ago by Hannes Payer (out of office)

Modified:
6 years, 7 months ago

Reviewers:
Benedikt Meurer, mvstanton

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove global pretenuring mode. BUG= R=bmeurer@chromium.org, mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21511

Patch Set 3 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+153 lines, -153 lines)			Patch
M	src/flag-definitions.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/heap.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/hydrogen.cc	View	1 2	5 chunks	+9 lines, -22 lines	0 comments	Download
M	src/objects-inl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-heap.cc	View	1	17 chunks	+143 lines, -123 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

LGTM with nit https://codereview.chromium.org/304493002/diff/20001/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/304493002/diff/20001/src/hydrogen.cc#newcode9518 src/hydrogen.cc:9518: FLAG_allocation_site_pretenuring Nit: Simplify condition

6 years, 7 months ago (2014-05-27 06:27:41 UTC) #3

Hannes Payer (out of office)

https://codereview.chromium.org/304493002/diff/20001/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/304493002/diff/20001/src/hydrogen.cc#newcode9518 src/hydrogen.cc:9518: FLAG_allocation_site_pretenuring On 2014/05/27 06:27:41, Benedikt Meurer wrote: > Nit: ...

6 years, 7 months ago (2014-05-27 07:43:38 UTC) #5

Hannes Payer (out of office)

6 years, 7 months ago (2014-05-27 07:48:44 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 manually as r21511 (presubmit successful).

Expand Messages | Collapse Messages