Source/core/svg/animation/SVGSMILElement.cpp - Issue 304453002: Prepare SMILTimeContainer for oilpan

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/animation/SVGSMILElement.cpp

Issue 304453002: Prepare SMILTimeContainer for oilpan (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: address comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/animation/SVGSMILElement.cpp

diff --git a/Source/core/svg/animation/SVGSMILElement.cpp b/Source/core/svg/animation/SVGSMILElement.cpp

index a97bc50d29b62d72b57d37142800813dfc989bbc..54f5c5a45a9113cbbe931808d0aca72a20846060 100644

--- a/Source/core/svg/animation/SVGSMILElement.cpp

+++ b/Source/core/svg/animation/SVGSMILElement.cpp

@@ -205,7 +205,9 @@ SVGSMILElement::~SVGSMILElement()

smilRepeatEventSender().cancelEvent(this);

smilRepeatNEventSender().cancelEvent(this);

#if !ENABLE(OILPAN)

+ // FIXME: Oilpan: Clear |m_syncBaseDependents| using weak processing.

clearConditions();

if (m_timeContainer && m_targetElement && hasValidAttributeName())

m_timeContainer->unschedule(this, m_targetElement, m_attributeName);

#endif

@@ -1349,6 +1351,7 @@ void SVGSMILElement::Condition::trace(Visitor* visitor)

void SVGSMILElement::trace(Visitor* visitor)

{

visitor->trace(m_targetElement);

+ visitor->trace(m_timeContainer);

visitor->trace(m_conditions);

visitor->trace(m_syncBaseDependents);

SVGElement::trace(visitor);