Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: Source/core/svg/animation/SVGSMILElement.cpp

Issue 304453002: Prepare SMILTimeContainer for oilpan (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: change containers and evict invalid keys manually Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 #if !ENABLE(OILPAN) 200 #if !ENABLE(OILPAN)
201 clearResourceAndEventBaseReferences(); 201 clearResourceAndEventBaseReferences();
202 #endif 202 #endif
203 smilEndEventSender().cancelEvent(this); 203 smilEndEventSender().cancelEvent(this);
204 smilBeginEventSender().cancelEvent(this); 204 smilBeginEventSender().cancelEvent(this);
205 smilRepeatEventSender().cancelEvent(this); 205 smilRepeatEventSender().cancelEvent(this);
206 smilRepeatNEventSender().cancelEvent(this); 206 smilRepeatNEventSender().cancelEvent(this);
207 #if !ENABLE(OILPAN) 207 #if !ENABLE(OILPAN)
208 clearConditions(); 208 clearConditions();
209 if (m_timeContainer && m_targetElement && hasValidAttributeName()) 209 if (m_timeContainer && m_targetElement && hasValidAttributeName())
210 m_timeContainer->unschedule(this, m_targetElement, m_attributeName); 210 m_timeContainer->unschedule(this, m_targetElement, m_attributeName);
haraken 2014/05/27 08:25:56 Just to confirm: This code is already removed in o
kouhei (in TOK) 2014/05/28 01:00:50 For 209-210, yes. 208 is still wrong (added commen
haraken 2014/05/28 01:43:55 Thanks. Recently we're doing a lot of complicated
211 #endif 211 #endif
212 } 212 }
213 213
214 void SVGSMILElement::clearResourceAndEventBaseReferences() 214 void SVGSMILElement::clearResourceAndEventBaseReferences()
215 { 215 {
216 document().accessSVGExtensions().removeAllTargetReferencesForElement(this); 216 document().accessSVGExtensions().removeAllTargetReferencesForElement(this);
217 } 217 }
218 218
219 void SVGSMILElement::clearConditions() 219 void SVGSMILElement::clearConditions()
220 { 220 {
(...skipping 1121 matching lines...) Expand 10 before | Expand all | Expand 10 after
1342 } 1342 }
1343 1343
1344 void SVGSMILElement::Condition::trace(Visitor* visitor) 1344 void SVGSMILElement::Condition::trace(Visitor* visitor)
1345 { 1345 {
1346 visitor->trace(m_syncBase); 1346 visitor->trace(m_syncBase);
1347 } 1347 }
1348 1348
1349 void SVGSMILElement::trace(Visitor* visitor) 1349 void SVGSMILElement::trace(Visitor* visitor)
1350 { 1350 {
1351 visitor->trace(m_targetElement); 1351 visitor->trace(m_targetElement);
1352 visitor->trace(m_timeContainer);
1352 visitor->trace(m_conditions); 1353 visitor->trace(m_conditions);
1353 visitor->trace(m_syncBaseDependents); 1354 visitor->trace(m_syncBaseDependents);
1354 SVGElement::trace(visitor); 1355 SVGElement::trace(visitor);
1355 } 1356 }
1356 1357
1357 } 1358 }
OLDNEW
« Source/core/svg/animation/SMILTimeContainer.cpp ('K') | « Source/core/svg/animation/SVGSMILElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698