Issue 30443003: Use JS Date().toLocaleDateString() to format date in header.

Issue 30443003: Use JS Date().toLocaleDateString() to format date in header. (Closed)

Created:
7 years, 2 months ago by Vitaly Buka (NO REVIEWS)

Modified:
7 years, 2 months ago

Reviewers:
Lei Zhang, Cris Neckar

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use JS Date().toLocaleDateString() to format date in header. Fixed issues with local date formats. Remove date from printing settings. BUG=103111 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230283

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -20 lines)			Patch
M	chrome/browser/printing/printing_message_filter.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/print_preview/print_preview_page.html	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/common/print_messages.h	View		2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/common/print_messages.cc	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/renderer/mock_printer.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/renderer/mock_printer.cc	View		4 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/renderer/printing/print_web_view_helper.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	printing/print_settings.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	printing/print_settings.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	printing/print_settings_initializer.cc	View	1	3 chunks	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 12 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

https://codereview.chromium.org/30443003/diff/30001/chrome/renderer/printing/print_web_view_helper.cc File chrome/renderer/printing/print_web_view_helper.cc (right): https://codereview.chromium.org/30443003/diff/30001/chrome/renderer/printing/print_web_view_helper.cc#newcode1487 chrome/renderer/printing/print_web_view_helper.cc:1487: static_cast<int>(base::Time::Now().ToDoubleT())); Is base::Time::ToJsTime() more appropriate here? You can use ...

7 years, 2 months ago (2013-10-22 18:45:17 UTC) #2

Vitaly Buka (NO REVIEWS)

7 years, 2 months ago (2013-10-22 21:24:40 UTC) #3