Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 304423004: ServiceWorker: Scope should match url in longest-prefix-match way (won't commit) (Closed)

Created:
6 years, 6 months ago by nhiroki
Modified:
6 years, 6 months ago
CC:
chromium-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, darin-cc_chromium.org, horo+watch_chromium.org, alecflett+watch_chromium.org
Visibility:
Public.

Description

ServiceWorker: Scope should match url in longest-prefix-match way Current implementation matches a registration in the first-match way, but the spec[1] requires to match one in the longest-prefix-match way. To support it, this CL introduces FindLongestScopeMatch(). [1] http://www.w3.org/TR/2014/WD-service-workers-20140508/ BUG=370773 TEST=content_unittests --gtest_filter=ServiceWorkerStorageTest.* TEST=content_unittests --gtest_filter=ServiceWorkerUtilsTest.*

Patch Set 1 : remake (drop the exact-match) #

Total comments: 1

Patch Set 2 : fix compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -16 lines) Patch
M content/browser/service_worker/service_worker_storage.cc View 2 chunks +19 lines, -16 lines 0 comments Download
M content/browser/service_worker/service_worker_storage_unittest.cc View 1 2 chunks +109 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_utils.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_utils.cc View 1 2 chunks +20 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_utils_unittest.cc View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nhiroki
Hi, can you review this? Let me open a new review for the longest-prefix-match change ...
6 years, 6 months ago (2014-06-02 17:41:11 UTC) #1
michaeln
Since theres lots of review history, and new comments, on the other cl which is ...
6 years, 6 months ago (2014-06-02 20:20:26 UTC) #2
nhiroki
On 2014/06/02 20:20:26, michaeln wrote: > Since theres lots of review history, and new comments, ...
6 years, 6 months ago (2014-06-02 22:23:38 UTC) #3
jsbell
On 2014/06/02 22:23:38, nhiroki wrote: > On 2014/06/02 20:20:26, michaeln wrote: > > Since theres ...
6 years, 6 months ago (2014-06-02 23:11:26 UTC) #4
nhiroki
6 years, 6 months ago (2014-06-03 01:56:17 UTC) #5
Message was sent while issue was closed.
On 2014/06/02 23:11:26, jsbell wrote:
> On 2014/06/02 22:23:38, nhiroki wrote:
> > On 2014/06/02 20:20:26, michaeln wrote:
> > > Since theres lots of review history, and new comments, on the other cl
which
> > is
> > > nearly identical, lets use that one for this patch.
> > 
> > Okay, let's go back. I'll mark this close.
> 
> Oops, sorry about the churn. I clicked a link in email and didn't notice I was
> commenting on the old patch #. :(

Np! Instead I'm sorry to forget to send notification of new one to the old :(

Powered by Google App Engine
This is Rietveld 408576698