content/shell/renderer/DEPS - Issue 304403002: Gamepad: add test support for page visibility behavior

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/shell/renderer/DEPS

Issue 304403002: Gamepad: add test support for page visibility behavior (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: trivial rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/renderer/gamepad_shared_memory_reader.h ('K') | « content/renderer/renderer_webkitplatformsupport_impl.cc ('k') | content/shell/renderer/test_runner/WebTestDelegate.h » ('j') | content/shell/renderer/test_runner/WebTestDelegate.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

	2 "+content/renderer",
	jam 2014/06/18 23:23:42 this isn't allowed. content/shell is just an embed this isn't allowed. content/shell is just an embedder of content, so it can only include stuff from content/public. i don't actually see any new includes to content/renderer though, why add this? kbalazs 2014/06/19 00:18:41 Yep, it was just a left behind from an early versi Show quoted text On 2014/06/18 23:23:42, jam wrote: > this isn't allowed. content/shell is just an embedder of content, so it can only > include stuff from content/public. i don't actually see any new includes to > content/renderer though, why add this? Yep, it was just a left behind from an early version. All comments addressed, PTAL.
2 "+gin",	3 "+gin",

3 ]	4 ]

OLD	NEW