Add support for modifying TCP and UDP socket buffer size in nacl_io

native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <arpa/inet.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <netinet/in.h>
 #include <pthread.h>
 #include <sys/types.h>
@@ skipping 566 matching lines @@
 
   free(inbuf);
   free(outbuf);
 }
 
 TEST_F(SocketTestUDP, Listen) {
   EXPECT_EQ(-1, ki_listen(sock1_, 10));
   EXPECT_EQ(errno, ENOTSUP);
 }
 
+TEST_F(SocketTestUDP, Sockopt_BUFSIZE) {
+  int option = 1024*1024;
+  socklen_t len = sizeof(option);
+
+  ASSERT_EQ(0, Bind(sock1_, LOCAL_HOST, ANY_PORT));
+  ASSERT_EQ(0, ki_setsockopt(sock1_, SOL_SOCKET, SO_RCVBUF, &option, len))
+    << "failed with: " << strerror(errno);
+  ASSERT_EQ(0, ki_setsockopt(sock1_, SOL_SOCKET, SO_SNDBUF, &option, len))
+    << "failed with: " << strerror(errno);

[Sam Clegg, 2014/06/03 00:07:54]

Can you verify the result with getsockopt()?

[mbajpai, 2014/06/03 05:11:07]

It is not clear to me how to do it. Unlike SetOption, TCP/UDP interface doesn't
have GetOption call implemented. 
Other option would be to save the value in udp_node.cc class but since the OS
can change the actual buffer size, I did not like that idea.

I notice that some trybot tests are failing. I have no idea, why.

+}
+
 TEST_F(SocketTestTCP, Listen) {
   sockaddr_in addr;
   socklen_t addrlen = sizeof(addr);
   const char* client_greeting = "hello";
   const char* server_reply = "reply";
   const int greeting_len = strlen(client_greeting);
   const int reply_len = strlen(server_reply);
 
   int server_sock = sock1_;
 
@@ skipping 208 matching lines @@
   int remainder = SEND_BYTES;
   while (remainder > 0) {
     int rtn = ki_recv(new_sock, buffer, remainder, 0);
     ASSERT_GT(rtn, 0);
     remainder -= rtn;
   }
 
   ASSERT_EQ(0, ki_close(new_sock));
 }
 
+TEST_F(SocketTestTCP, Sockopt_BUFSIZE) {
+  int option = 1024*1024;
+  socklen_t len = sizeof(option);
+  sockaddr_in addr;
+  socklen_t addrlen = sizeof(addr);
+
+  int server_sock = sock1_;
+  int client_sock = sock2_;
+
+  // bind and listen
+  ASSERT_EQ(0, Bind(server_sock, LOCAL_HOST, ANY_PORT));
+  ASSERT_EQ(0, ki_listen(server_sock, 10))
+    << "listen failed with: " << strerror(errno);
+
+  // connect to listening socket
+  IP4ToSockAddr(LOCAL_HOST, PORT1, &addr);
+  ASSERT_EQ(0, ki_connect(client_sock, (sockaddr*)&addr, addrlen))
+    << "Failed with " << errno << ": " << strerror(errno);
+
+  addrlen = sizeof(addr);
+  int new_sock = accept(server_sock, (sockaddr*)&addr, &addrlen);
+  ASSERT_NE(-1, new_sock);
+
+  ASSERT_EQ(0, ki_setsockopt(sock2_, SOL_SOCKET, SO_RCVBUF, &option, len))
+      << "failed with: " << strerror(errno);
+  ASSERT_EQ(0, ki_setsockopt(sock2_, SOL_SOCKET, SO_SNDBUF, &option, len))
+      << "failed with: " << strerror(errno);

[Sam Clegg, 2014/06/03 00:07:54]

ditto.

+}
+
 #endif  // PROVIDES_SOCKET_API