Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 304353015: Remove unused Isolate* parameters from toV8Context() (Closed)

Created:
6 years, 6 months ago by haraken
Modified:
6 years, 6 months ago
CC:
blink-reviews, vsevik+blink_chromium.org, caseq+blink_chromium.org, arv+blink, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, loislo+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Remove unused Isolate* parameters from toV8Context() TBR=jochen Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175266

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -30 lines) Patch
M Source/bindings/v8/NPV8Object.cpp View 12 chunks +13 lines, -13 lines 0 comments Download
M Source/bindings/v8/ScriptController.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/ScriptPreprocessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/ScriptState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8Binding.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8Binding.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8HTMLDocumentCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8WindowCustom.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorOverlay.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/InspectorFrontendClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebDevToolsFrontendImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
haraken
PTAL
6 years, 6 months ago (2014-06-02 05:56:41 UTC) #1
kouhei (in TOK)
On 2014/06/02 05:56:41, haraken wrote: > PTAL lgtm
6 years, 6 months ago (2014-06-02 06:00:11 UTC) #2
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 6 months ago (2014-06-02 06:35:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/304353015/1
6 years, 6 months ago (2014-06-02 06:35:21 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-02 07:48:13 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-02 09:14:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/6647)
6 years, 6 months ago (2014-06-02 09:14:16 UTC) #7
haraken
TBRing jochen@ for web/
6 years, 6 months ago (2014-06-02 09:38:11 UTC) #8
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 6 months ago (2014-06-02 09:38:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/304353015/1
6 years, 6 months ago (2014-06-02 09:38:43 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 09:52:52 UTC) #11
Message was sent while issue was closed. 
Change committed as 175266

Powered by Google App Engine
This is Rietveld 408576698