Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: net/spdy/spdy_stream_unittest.cc

Issue 304353012: Introduce STATE_RESERVED_REMOTE. No behavioral changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix review remarks Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/spdy/spdy_stream.cc ('K') | « net/spdy/spdy_stream.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_stream_unittest.cc
diff --git a/net/spdy/spdy_stream_unittest.cc b/net/spdy/spdy_stream_unittest.cc
index 8f46abe083b16d242c9a36a14ec34279d415344f..f754be662c7c6f71a04ca6a32f114b1f162e6024 100644
--- a/net/spdy/spdy_stream_unittest.cc
+++ b/net/spdy/spdy_stream_unittest.cc
@@ -199,16 +199,22 @@ TEST_P(SpdyStreamTest, PushedStream) {
stream.set_stream_id(2);
EXPECT_FALSE(stream.HasUrlFromHeaders());
- // Set a couple of headers.
+ // Set required request headers.
+ SpdyHeaderBlock request_headers;
+ spdy_util_.AddUrlToHeaderBlock(kStreamUrl, &request_headers);
+ stream.OnPushPromiseHeadersReceived(request_headers);
+
+ // Send some basic response headers.
SpdyHeaderBlock response;
- spdy_util_.AddUrlToHeaderBlock(kStreamUrl, &response);
+ response[spdy_util_.GetStatusKey()] = "200";
+ response[spdy_util_.GetVersionKey()] = "OK";
stream.OnInitialResponseHeadersReceived(
response, base::Time::Now(), base::TimeTicks::Now());
- // Send some basic headers.
+ // And some more headers.
+ // TODO(baranovich): not valid for HTTP 2.
SpdyHeaderBlock headers;
- headers[spdy_util_.GetStatusKey()] = "200";
- headers[spdy_util_.GetVersionKey()] = "OK";
+ headers["alpha"] = "beta";
stream.OnAdditionalResponseHeadersReceived(headers);
EXPECT_TRUE(stream.HasUrlFromHeaders());
@@ -220,6 +226,7 @@ TEST_P(SpdyStreamTest, PushedStream) {
base::MessageLoop::current()->RunUntilIdle();
EXPECT_EQ("200", delegate.GetResponseHeaderValue(spdy_util_.GetStatusKey()));
+ EXPECT_EQ("beta", delegate.GetResponseHeaderValue("alpha"));
EXPECT_TRUE(spdy_session == NULL);
}
« net/spdy/spdy_stream.cc ('K') | « net/spdy/spdy_stream.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698